Skip to content

[Release 5.2] ESRP federated credential update (move to AME) (#3261) #3266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

[Release 5.2] ESRP federated credential update (move to AME) (#3261) #3266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 32 additions & 14 deletions eng/pipelines/common/templates/steps/esrp-code-signing-step.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ parameters:
type: string
default: $(artifactDirectory)

- name: ESRPConnectedServiceName
type: string
default: $(ESRPConnectedServiceName)

- name: appRegistrationClientId
type: string
default: $(appRegistrationClientId)
Expand All @@ -25,29 +29,42 @@ parameters:
type: string
default: $(appRegistrationTenantId)

- name: AuthAKVName
type: string
default: $(AuthAKVName)

- name: AuthSignCertName
type: string
default: $(AuthSignCertName)

- name: EsrpClientId
type: string
default: $(EsrpClientId)

steps:
- ${{ if eq(parameters.artifactType, 'dll') }}:
- task: EsrpMalwareScanning@5
displayName: 'ESRP MalwareScanning'
inputs:
ConnectedServiceName: 'ESRP Workload Identity federation service-ADO.Net'
ConnectedServiceName: '${{parameters.ESRPConnectedServiceName }}'
AppRegistrationClientId: '${{parameters.appRegistrationClientId }}'
AppRegistrationTenantId: '${{parameters.appRegistrationTenantId }}'
AuthAKVName: SqlClientDrivers
AuthCertName: 'ESRP-Release-Auth'
EsrpClientId: '${{parameters.EsrpClientId }}'
UseMSIAuthentication: true
FolderPath: '${{parameters.sourceRoot }}'
Pattern: '*.dll'
CleanupTempStorage: 1
VerboseLogin: 1
- task: EsrpCodeSigning@5
displayName: 'ESRP CodeSigning'
inputs:
ConnectedServiceName: 'ESRP Workload Identity federation service-ADO.Net'
ConnectedServiceName: '${{parameters.ESRPConnectedServiceName }}'
AppRegistrationClientId: '${{parameters.appRegistrationClientId }}'
AppRegistrationTenantId: '${{parameters.appRegistrationTenantId }}'
AuthAKVName: SqlClientDrivers
AuthCertName: 'ESRP-Release-Auth'
AuthSignCertName: 'ESRP-Release-Sign2'
EsrpClientId: '${{parameters.EsrpClientId }}'
UseMSIAuthentication: true
AuthAKVName: '${{parameters.AuthAKVName }}'
AuthSignCertName: '${{parameters.AuthSignCertName }}'
FolderPath: '${{parameters.sourceRoot }}'
Pattern: '*.dll'
signConfigType: inlineSignParams
Expand Down Expand Up @@ -94,24 +111,25 @@ steps:
- task: EsrpMalwareScanning@5
displayName: 'ESRP MalwareScanning Nuget Package'
inputs:
ConnectedServiceName: 'ESRP Workload Identity federation service-ADO.Net'
ConnectedServiceName: '${{parameters.ESRPConnectedServiceName }}'
AppRegistrationClientId: '${{parameters.appRegistrationClientId }}'
AppRegistrationTenantId: '${{parameters.appRegistrationTenantId }}'
AuthAKVName: SqlClientDrivers
AuthCertName: 'ESRP-Release-Auth'
EsrpClientId: '${{parameters.EsrpClientId }}'
UseMSIAuthentication: true
FolderPath: '${{parameters.artifactDirectory }}'
Pattern: '*.*nupkg'
CleanupTempStorage: 1
VerboseLogin: 1
- task: EsrpCodeSigning@5
displayName: 'ESRP CodeSigning Nuget Package'
inputs:
ConnectedServiceName: 'ESRP Workload Identity federation service-ADO.Net'
ConnectedServiceName: '${{parameters.ESRPConnectedServiceName }}'
AppRegistrationClientId: '${{parameters.appRegistrationClientId }}'
AppRegistrationTenantId: '${{parameters.appRegistrationTenantId }}'
AuthAKVName: SqlClientDrivers
AuthCertName: 'ESRP-Release-Auth'
AuthSignCertName: 'ESRP-Release-Sign2'
EsrpClientId: '${{parameters.EsrpClientId }}'
UseMSIAuthentication: true
AuthAKVName: '${{parameters.AuthAKVName }}'
AuthSignCertName: '${{parameters.AuthSignCertName }}'
FolderPath: '${{parameters.artifactDirectory }}'
Pattern: '*.*nupkg'
signConfigType: inlineSignParams
Expand Down
12 changes: 8 additions & 4 deletions eng/pipelines/libraries/common-variables.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,14 @@
#################################################################################

variables:
- group: ESRP Federated Creds (AME)
# ESRPConnectedServiceName
# ESRPClientId
# AppRegistrationClientId
# AppRegistrationTenantId
# AuthAKVName
# AuthSignCertName

- name: Configuration
value: Release
- name: CommitHead
Expand All @@ -17,7 +25,3 @@ variables:
value: $(REPOROOT)/symbols
- name: artifactDirectory
value: '$(REPOROOT)/packages'
- name: appRegistrationClientId
value: 'a0d18a38-fde1-4ba7-92e1-15be16cb6a8e'
- name: appRegistrationTenantId
value: '72f988bf-86f1-41af-91ab-2d7cd011db47'
Loading