Get/Return pooled connections #3404

mdaigle · 2025-06-09T19:11:03Z

Description

This PR adds Get and Return functionality to the new ChannelDbConnectionPool class.
A channel and corresponding channel reader and writer are added to underpin these operations.
An array is added to hold references to all connections managed by the pool.
Logic is included to respect max pool size in all cases.

Not included: pool warm up (including respecting min pool size), pool pruning, transactions, tracing/logs. These will come in follow-up PRs.

Also includes extensive unit test coverage for the implemented functionality. Integration testing is reserved for a later state when more of the pool functionality is available.

Issues

#3356

Testing

Tests focus on the Get and Return flows with special focus on the following:

async behavior
max pool size respected
connections successfully reused
requests successfully queued and queue order respected
stress testing with many parallel operations

mdaigle · 2025-06-09T20:46:54Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs

@@ -97,6 +97,8 @@ internal DbConnectionInternal(ConnectionState state, bool hidePassword, bool all

        #region Properties

+        internal DateTime CreateTime => _createTime;


Exposes creation time for load balancing and max connection lifetime enforcement.

Why to make getter and setter internal ?

It looks like this class DbConnectionInternal is managing its creation time, and this value isn’t exposed to derived classes.

If there’s any chance that this responsibility might shift in the future, or if derived classes may need to update the creation time, I recommend adding a protected method (e.g., UpdateCreationTime(DateTime newTime)) rather than exposing a protected setter or property.

My reasoning is:

Updating creation time should be an explicit, intentional action, not just a simple property assignment. An explicit method makes this clear in the API and signals that it’s a special operation as most of the logic is still in the base.

Let me know your thoughts.

Agreed. Other classes shouldn't be updating this property. This syntax will only expose a getter for the property: https://learn.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/properties#expression-body-definitions

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

mdaigle · 2025-06-10T16:25:05Z

@roji tagging you here if you have any time to review. Thanks!

benrr101

In general, it looks good. A bunch of things I'd like addressed, but you know I'll accept valid arguments against fixing them :)

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

...lient/tests/UnitTests/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPoolTest.cs

paulmedynski

I have reviewed the ChannelDbConnectionPool changes. I will look at the tests once we have converged on an implementation. It might be a good idea to host another meeting to walk through the commentary here.

tools/props/Versions.props

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

paulmedynski · 2025-06-13T12:09:16Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+            for (var numConnections = _numConnections; numConnections < MaxPoolSize; numConnections = _numConnections)
+            {
+                // Note that we purposefully don't use SpinWait for this: https://github.com/dotnet/coreclr/pull/21437
+                if (Interlocked.CompareExchange(ref _numConnections, numConnections + 1, numConnections) != numConnections)


This is complicated enough to warrant an English explanation of what's happening.

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

paulmedynski · 2025-06-13T12:13:12Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+
+                    return Task.FromResult<DbConnectionInternal?>(newConnection);
+                }
+                catch


Catch only what is documented to be thrown.

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

imasud00 · 2025-06-17T08:27:03Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// </summary>
+        private static int _instanceCount;
+
+        private readonly int _instanceID = Interlocked.Increment(ref _instanceCount);


Interlocked.Increment(ref _instanceCount);

does it matter if it becomes negative ?

it starts at zero and only ever goes up

Counters are naturally unsigned, so can we use uint or ulong instead? I'd be proud if those ever wrapped :)

Also, should this be _instanceId ?

There's no Interlocked.Increment() overload for uint. It doesn't matter if it goes negative. It's only used for identification of unique pools in trace messages.

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

imasud00 · 2025-06-17T19:05:51Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

@@ -20,52 +25,136 @@ namespace Microsoft.Data.SqlClient.ConnectionPool
    /// </summary>
    internal sealed class ChannelDbConnectionPool : IDbConnectionPool


ChannelDbConnectionPool

it might be good to add some documentation on how this class works and how this is different than the WaitHandleDbConnectionPool.

imasud00 · 2025-06-17T19:26:35Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        }
+
+        /// <inheritdoc/>
+        internal Task<DbConnectionInternal?> OpenNewInternalConnection(DbConnection? owningConnection, DbConnectionOptions userOptions, TimeSpan timeout, bool async, CancellationToken cancellationToken)


OpenNewInternalConnection

could we refactor this code for better readbility.
shared refactor code. Compisition here making this code easy

internal Task<DbConnectionInternal?> OpenNewInternalConnection(DbConnection? owningConnection, DbConnectionOptions userOptions, TimeSpan timeout, bool async, CancellationToken cancellationToken) { while (TryReserveConnectionSlot()) { try { var connection = CreateAndTrackPhysicalConnection(owningConnection, userOptions); return Task.FromResult<DbConnectionInternal?>(connection); } catch { ReleaseConnectionSlot(); SignalWaiters(); throw; } } return Task.FromResult<DbConnectionInternal?>(null); }

imasud00 · 2025-06-17T19:28:49Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+
+                try
+                {
+                    // We've managed to increase the open counter, open a physical connection.


We've managed to increase the open counter, open a physical connection.

private bool TryReserveConnectionSlot() { int current; while ((current = _numConnections) < MaxPoolSize) { if (Interlocked.CompareExchange(ref _numConnections, current + 1, current) == current) { return true; } } return false; }

private void ReleaseConnectionSlot() { Interlocked.Decrement(ref _numConnections); }

private void SignalWaiters() { _idleConnectionWriter.TryWrite(null); }

imasud00 · 2025-06-17T19:30:08Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+                     * throughput high than to queue all of our opens onto a single worker thread. Add an async path 
+                     * when this support is added to DbConnectionInternal.
+                     */
+                    DbConnectionInternal? newConnection = ConnectionFactory.CreatePooledConnection(


ConnectionFactory

private DbConnectionInternal CreateAndTrackPhysicalConnection(DbConnection? owningConnection, DbConnectionOptions userOptions) { DbConnectionInternal? newConnection = ConnectionFactory.CreatePooledConnection( this, owningConnection, PoolGroup.ConnectionOptions, PoolGroup.PoolKey, userOptions); if (newConnection == null) { throw ADP.InternalError(ADP.InternalErrorCode.CreateObjectReturnedNull); } if (!newConnection.CanBePooled) { throw ADP.InternalError(ADP.InternalErrorCode.NewObjectCannotBePooled); } newConnection.PrePush(null); if (!TryTrackConnectionInSlot(newConnection)) { ReleaseConnectionSlot(); SignalWaiters(); throw new InvalidOperationException("No available slot to track new connection."); } return newConnection; }

imasud00 · 2025-06-17T19:30:28Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+                    // We've managed to increase the open counter, open a physical connection.
+                    var startTime = Stopwatch.GetTimestamp();
+
+                    /* TODO: This blocks the thread for several network calls!


Do we have bug that is tracking to make this change ?

mdaigle · 2025-06-17T23:01:56Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+                    Debug.Assert(i < MaxPoolSize, $"Could not find free slot in {_connections} when opening.");
+                    if (i == MaxPoolSize)
+                    {
+                        //TODO: generic exception?


In this case, maybe we should close the connection and pretend we never created it

mdaigle · 2025-06-17T23:14:51Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+                        throw ADP.InternalError(ADP.InternalErrorCode.NewObjectCannotBePooled);
+                    }
+
+                    newConnection.PrePush(null);


consider wrapping in a more meaningful name

imasud00 · 2025-06-18T05:40:20Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// </summary>
+        /// <param name="connection"></param>
+        /// <returns>Returns true if the connection is live and unexpired, otherwise returns false.</returns>
+        private bool CheckConnection(DbConnectionInternal connection)


CheckConnection

CloseExpiredConnection().

imasud00 · 2025-06-18T20:19:59Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+            // This connection was tracked by the pool, so closing it has opened a free spot in the pool.
+            // Write a null to the idle connection channel to wake up a waiter, who can now open a new
+            // connection. Statement order is important since we have synchronous completions on the channel.
+            _idleConnectionWriter.TryWrite(null);


Instead of CloseConnetion. I will save RemoveConnection (could you add bool dipose which could be true by default or false)

I think the logic should be inversed.

We should first remove this conneciton from the slots and then call dispose(). This ensures that pool get cleared and dispose is best effort even if for any reason dispose throuws an exception we are good that we have cleaned up the slot.

benrr101

Sorry, needs another round... But the other first round was pretty good!

benrr101 · 2025-06-18T23:48:09Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs

+        /// </summary>
+        internal DateTime CreateTime
+        {
+            get;


nit: these can/should be on the same line

benrr101 · 2025-06-18T23:49:53Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// </summary>
+        private static int _instanceCount;
+
+        private readonly int _instanceID = Interlocked.Increment(ref _instanceCount);


it starts at zero and only ever goes up

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

benrr101 · 2025-06-18T23:51:19Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// <inheritdoc />
+        public DbConnectionPoolIdentity Identity
+        {
+            get;


Ok I rescind my Nit designation - let's get these on the same line

benrr101 · 2025-06-18T23:52:07Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+            }
+
+            /* 
+                * This is ugly, but async anti-patterns above and below us in the stack necessitate a fresh task to be


nit: I think your indentation got messed up here

benrr101 · 2025-06-18T23:53:11Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        }
+
+        /// <inheritdoc/>
+        internal Task<DbConnectionInternal?> OpenNewInternalConnection(DbConnection? owningConnection, DbConnectionOptions userOptions, TimeSpan timeout, bool async, CancellationToken cancellationToken)


Please chomp this biggie of a line :)

benrr101 · 2025-06-19T00:01:40Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

@@ -389,7 +500,7 @@ private async Task<DbConnectionInternal> GetInternalConnection(DbConnection owni
            try
            {
                // Continue looping around until we create/retrieve a connection or the timeout expires.
-                while (true)
+                while (true && !finalToken.IsCancellationRequested)


.... true is completely redundant now, lol

I'd rather have a while(true) than while(!finalToken.IsCancellationRequested). At least I know intuitively that while(true) implies we'll break out somewhere inside. The latter implies we run this code until timeout... And the combination is just, well redundant 😂

It would be nice if there was a way to have the condition of the while be while(connection is null && finalToken.IsCancellationRequested). Which I think is what we were working towards by suggesting a do/while loop - basically make at least one attempt to get a connection, and loop around if we haven't. I'd suggest then making it like:

do { finalToken.ThrowIfCancelled(); // do stuff to set connection } while(connection is null); return connection;

the latest refactor should help with this. coming soon!

samsharma2700 · 2025-06-19T19:53:57Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        private readonly ChannelWriter<DbConnectionInternal?> _idleConnectionWriter;
+
+        // Counts the total number of open connections tracked by the pool.
+        private volatile int _numConnections;


When will this be different than the size of _connections array?

samsharma2700 · 2025-06-19T19:54:11Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+            // We enforce Max Pool Size, so no need to create a bounded channel (which is less efficient)
+            // On the consuming side, we have the multiplexing write loop but also non-multiplexing Rents
+            // On the producing side, we have connections being released back into the pool (both multiplexing and not)
+            var idleChannel = Channel.CreateUnbounded<DbConnectionInternal?>();


I agree with the efficiency argument but have we compared the difference in performance for our specific use case implementation for Bounded vs Unbounded Channel. Bounded channel can offload the part of us worrying about Max/Min poolsize, flooding and starvation in exchange for some throughput loss.

samsharma2700 · 2025-06-19T22:45:54Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// Tracks all connections currently managed by this pool, whether idle or busy.
+        /// Only updated rarely - when physical connections are opened/closed - but is read in perf-sensitive contexts.
+        /// </summary>
+        private readonly DbConnectionInternal?[] _connections;


So in essence _numConnections is doing the reservation part for us. Does the array itself provide any thing that Concurrent Bag/Dictionary/Queue will not provide. SemaphoreSlim does look seem to be the lightest, thread-safe solution here.

paulmedynski

A new round of comments, questions, and suggestions :)

paulmedynski · 2025-06-20T14:54:35Z

src/Microsoft.Data.SqlClient/src/System/Runtime/CompilerServices/IsExternalInit.netfx.cs

+
+using System.ComponentModel;
+
+


Extra blank line.

paulmedynski · 2025-06-20T15:00:38Z

src/Microsoft.Data.SqlClient/src/System/Runtime/CompilerServices/IsExternalInit.netfx.cs

+using System.ComponentModel;
+
+
+// This class enables the use of the `init` property accessor in .NET framework.


Can you link to documentation on why this is necessary? I found this:

https://blog.ndepend.com/using-c9-record-and-init-property-in-your-net-framework-4-x-net-standard-and-net-core-projects/

paulmedynski · 2025-06-20T15:03:22Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// </summary>
+        private static int _instanceCount;
+
+        private readonly int _instanceID = Interlocked.Increment(ref _instanceCount);


Counters are naturally unsigned, so can we use uint or ulong instead? I'd be proud if those ever wrapped :)

paulmedynski · 2025-06-20T15:05:43Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+            PoolGroupOptions = connectionPoolGroup.PoolGroupOptions;
+            ProviderInfo = connectionPoolProviderInfo;
+            Identity = identity;
+            AuthenticationContexts = new();


What's our take on initializing fields/properties that don't depend on a constructor body? Do we prefer to do it in each constructor, or do it on the field/property declaration? I prefer the latter. We've got a mix in this class so far (see _instanceID line 40).

I don't really have a preference here. Maybe a slight preference towards doing it in the constructor for instance variables, doing it outside the constructor (where possible) for statics. But I think I have more of a preference for not having a preference :)

paulmedynski · 2025-06-20T15:06:01Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// </summary>
+        private static int _instanceCount;
+
+        private readonly int _instanceID = Interlocked.Increment(ref _instanceCount);


Also, should this be _instanceId ?

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

paulmedynski · 2025-06-20T15:08:59Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        public DbConnectionPoolIdentity Identity
+        {
+            get;
+            private set;


Can this be init too?

paulmedynski · 2025-06-20T15:19:31Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

+        /// <inheritdoc />
+        public bool TryGetConnection(DbConnection owningObject, TaskCompletionSource<DbConnectionInternal> taskCompletionSource, DbConnectionOptions userOptions, out DbConnectionInternal? connection)
+        {
+            // If taskCompletionSource is null, we are in a sync context.


Can you use ? notation on the argument type here, even though it's not specified on the IDbConnectionPool method?

It should work fine, but I made the interface method use ? as well for clarity.

paulmedynski · 2025-06-20T15:25:41Z

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs

-
-        /// <inheritdoc />
-        public bool TryGetConnection(DbConnection owningObject, TaskCompletionSource<DbConnectionInternal> taskCompletionSource, DbConnectionOptions userOptions, out DbConnectionInternal? connection)
+        /// <returns>Returns true if a valid idle connection is found, otherwise returns false.</returns>


This method doesn't return bool.

mdaigle added 4 commits June 9, 2025 13:44

Add get flow and basic tests.

87a1129

Add tests. Clean up diff.

4233f94

Add additional tests. Refactor to test error behavior.

fb8c9d0

Implement return flow and add return/reuse tests.

73a379b

mdaigle force-pushed the dev/mdaigle/get-return-pooled-connections branch from 9d95355 to 73a379b Compare June 9, 2025 20:45

mdaigle commented Jun 9, 2025

View reviewed changes

mdaigle added 2 commits June 9, 2025 15:19

Clean up comments and todos.

7ac22f6

Add test cases.

7c75930

mdaigle mentioned this pull request Jun 5, 2025

Redesign the SqlClient Connection Pool to Improve Performance and Async Support #3356

Open

mdaigle changed the title ~~Dev/mdaigle/get return pooled connections~~ Get/Return pooled connections Jun 9, 2025

mdaigle marked this pull request as ready for review June 9, 2025 23:25

mdaigle requested a review from a team as a code owner June 9, 2025 23:25

edwardneal reviewed Jun 10, 2025

View reviewed changes

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs Show resolved Hide resolved

benrr101 requested changes Jun 11, 2025

View reviewed changes

mdaigle added 6 commits June 12, 2025 10:40

Enable init property accessor in netfx.

6dde5b9

Switch to auto properties.

9999bf7

Reorder class members.

931ac03

Address review comments.

7d734f9

Merge main

12a8121

Fix channels package resolution.

ec27e63

paulmedynski requested changes Jun 13, 2025

View reviewed changes

Review changes.

c4d5808

imasud00 reviewed Jun 17, 2025

View reviewed changes

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs Show resolved Hide resolved

imasud00 reviewed Jun 17, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbConnectionInternal.cs Show resolved Hide resolved

vonzshik reviewed Jun 17, 2025

View reviewed changes

...rosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/ChannelDbConnectionPool.cs Show resolved Hide resolved

imasud00 reviewed Jun 17, 2025

View reviewed changes

mdaigle commented Jun 17, 2025

View reviewed changes

imasud00 reviewed Jun 18, 2025

View reviewed changes

benrr101 requested changes Jun 19, 2025

View reviewed changes

samsharma2700 reviewed Jun 19, 2025

View reviewed changes

paulmedynski requested changes Jun 20, 2025

View reviewed changes

		@@ -97,6 +97,8 @@ internal DbConnectionInternal(ConnectionState state, bool hidePassword, bool all

		#region Properties

		internal DateTime CreateTime => _createTime;

		@@ -20,52 +25,136 @@ namespace Microsoft.Data.SqlClient.ConnectionPool
		/// </summary>
		internal sealed class ChannelDbConnectionPool : IDbConnectionPool

		using System.ComponentModel;


		// This class enables the use of the `init` property accessor in .NET framework.

Get/Return pooled connections #3404

Are you sure you want to change the base?

Get/Return pooled connections #3404

Conversation

mdaigle commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issues

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mdaigle commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benrr101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imasud00 Jun 17, 2025 • edited by benrr101 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imasud00 Jun 17, 2025 • edited by benrr101 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imasud00 Jun 17, 2025 • edited by benrr101 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

imasud00 Jun 17, 2025 • edited by benrr101 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

mdaigle commented Jun 9, 2025 •

edited

Loading

mdaigle commented Jun 10, 2025 •

edited

Loading

imasud00 Jun 17, 2025 •

edited by benrr101

Loading

imasud00 Jun 17, 2025 •

edited by benrr101

Loading

imasud00 Jun 17, 2025 •

edited by benrr101

Loading

imasud00 Jun 17, 2025 •

edited by benrr101

Loading

imasud00 Jun 18, 2025 •

edited

Loading