Tests | Expand UDT serialization code coverage #3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
Area\Tests
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
paulmedynski
requested changes
Jun 20, 2025
src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft.Data.SqlClient.UnitTests.csproj
Outdated
Show resolved
Hide resolved
...lClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs
Show resolved
Hide resolved
....Data.SqlClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/SerializedTypes.cs
Outdated
Show resolved
Hide resolved
...Client/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/InvalidSerializationTest.cs
Outdated
Show resolved
Hide resolved
...lClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs
Show resolved
Hide resolved
...lClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs
Outdated
Show resolved
Hide resolved
...Client/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/InvalidSerializationTest.cs
Outdated
Show resolved
Hide resolved
...lClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs
Outdated
Show resolved
Hide resolved
...lClient/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/NativeSerializationTest.cs
Outdated
Show resolved
Hide resolved
...nt/tests/UnitTests/Microsoft/Data/SqlClient/UdtSerialization/UserDefinedSerializationTest.cs
Outdated
Show resolved
Hide resolved
Also enforce this via editorconfig
Also mandating this by generating a documentation XML file
paulmedynski
approved these changes
Jun 25, 2025
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been looking at a set of performance improvements and code health improvements to the serialization of CLR UDTs - SqlNormalizer.cs and SqlSer.cs. At present though, there isn't sufficient test coverage to prevent regressions. This PR widens that coverage, adding a set of new unit tests for the serialization and deserialization of CLR UDTs. By the end of this, I think we cover every reachable branch.
This is also the first set of additional tests in the new UnitTests project, and the first tests which test current library functionality. I've got no objection if anyone wants to start the new project with a consistent code style.
Issues
None.
Testing
All tests pass, all values match existing behaviour.