Official pipeline tweaks - round 3 #3452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng an Official MDS package. - Added comments to Versions.props warning of fragile validation logic. - Improved comments in the validation pipeline job.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refines the Official pipeline’s package validation by adding a new runtime, calling out fragile ordering in version props, and polishing pipeline comments.
- Include
netstandard2.0in the list of expected .NET runtimes for package validation - Add “GOTCHA” comments in
Versions.propsto warn about hardcoded XML ordering - Improve readability and accuracy of comments in the validation job template
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/props/Versions.props | Annotated ordering dependencies and clarified version comments |
| eng/pipelines/libraries/mds-validation-variables.yml | Added netstandard2.0 to expectedDotnetVersions |
| eng/pipelines/common/templates/jobs/validate-signed-package-job.yml | Reformatted and enhanced PowerShell comments |
Comments suppressed due to low confidence (2)
tools/props/Versions.props:9
- Specify which two properties (e.g.,
AssemblyFileVersionandAssemblyVersion) to make the warning less ambiguous.
GOTCHA: These two properties must appear in the first <PropertyGroup> in
eng/pipelines/common/templates/jobs/validate-signed-package-job.yml:346
- Update this comment to reflect that the step actually modifies
TestMicrosoftDataSqlClientVersionrather than only checking versions.
# Check assembly versions.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
priyankatiwari08
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Another round of tweaks to get the Official pipeline working: