Skip to content

Conversation

@paulmedynski
Copy link
Contributor

Port of #3542.

  • Adjusted CodeQL suppression to meet the strict requirements of where it may appear relative to the flagged code.
  • Adding catch for macOS socket error to log and ignore.

…3542)

* Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production

- Adjusted CodeQL suppression to meet the strict requirements of where it may appear relative to the flagged code.

* Task 37261: [S360] [SM05137] DefaultAzureCredential use in Production

- Adding catch for macOS socket error to log and ignore.
@paulmedynski paulmedynski added this to the 6.1.1 milestone Aug 8, 2025
Copilot AI review requested due to automatic review settings August 8, 2025 12:39
@paulmedynski paulmedynski requested a review from a team as a code owner August 8, 2025 12:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ports changes from PR #3542 to the 6.1 branch, focusing on CodeQL suppression compliance and macOS CI stability. The changes address static analysis requirements and handle platform-specific socket errors.

  • Added proper CodeQL suppression with detailed justification for DefaultAzureCredential instantiation
  • Enhanced error handling for socket timeout operations on macOS with logging
  • Improved code structure by extracting constant and adding exception handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ActiveDirectoryAuthenticationProvider.cs Added CodeQL suppression with justification and restructured DefaultAzureCredential instantiation
SniTcpHandle.netcore.cs Added try-catch block for socket timeout reset with macOS-specific error handling and logging

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.82%. Comparing base (70d54d1) to head (f156064).
⚠️ Report is 3 commits behind head on release/6.1.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/6.1    #3550       +/-   ##
================================================
+ Coverage        66.03%   90.82%   +24.79%     
================================================
  Files              281        6      -275     
  Lines            62401      316    -62085     
================================================
- Hits             41205      287    -40918     
+ Misses           21196       29    -21167     
Flag Coverage Δ
addons 90.82% <ø> (ø)
netcore ?
netfx ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cheenamalhotra cheenamalhotra merged commit 7a7b54e into release/6.1 Aug 11, 2025
129 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/paul/release/6.1-codeql branch August 11, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants