Skip to content

Conversation

@cheenamalhotra
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings August 12, 2025 18:00
@cheenamalhotra cheenamalhotra requested a review from a team as a code owner August 12, 2025 18:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses missing project dependencies by adding explicit references to Azure.Core and other required packages across all SqlClient project files and configurations. The changes ensure proper dependency management for both .NET Framework and .NET Core implementations.

Key changes:

  • Adds Azure.Core as an explicit dependency across all target frameworks
  • Consolidates System.Configuration.ConfigurationManager references to apply to all frameworks
  • Adds missing package references for Microsoft.Extensions.Caching.Memory and Microsoft.IdentityModel packages

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/specs/Microsoft.Data.SqlClient.nuspec Adds Azure.Core 1.47.1 dependency to all target framework groups
src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj Consolidates package references and adds missing dependencies for all frameworks
src/Microsoft.Data.SqlClient/netfx/src/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Framework implementation
src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Framework reference assembly
src/Microsoft.Data.SqlClient/netcore/src/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Core implementation
src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.csproj Adds Azure.Core package reference for .NET Core reference assembly

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@cheenamalhotra cheenamalhotra changed the title Fix project dependencies [6.1] Fix project dependencies Aug 12, 2025
@cheenamalhotra cheenamalhotra added this to the 6.1.1 milestone Aug 12, 2025
@cheenamalhotra cheenamalhotra merged commit 495a39b into release/6.1 Aug 13, 2025
114 of 127 checks passed
@cheenamalhotra cheenamalhotra deleted the dev/cheena/6.1-deps branch August 13, 2025 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants