[6.1] AKV Provider Strong Name Signing #3573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make signing key path an argument to build and roslyn analyzers steps * Enable strong name signing on buddy (unofficial) builds * Add akv official job to solution file
benrr101
added
Area\AKV Provider
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a critical issue where official builds of the Azure Key Vault (AKV) provider were not being strong name signed due to a missing signing key path in the Roslyn analyzer step. The fix ensures that both the main build and Roslyn analyzer steps use the same signing configuration to maintain strong name signatures throughout the build process.
- Factors out the signing key path as a parameter to both build and Roslyn analyzer steps
- Updates the AKV provider project to enable signing for both Official and Buddy builds
- Adds diagnostics to help troubleshoot signing issues
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj | Extends signing configuration to include Buddy builds and reorganizes PropertyGroup structure |
| Microsoft.Data.SqlClient.sln | Adds build job YAML file to solution items for better visibility |
| roslyn-analyzers-akv-step.yml | Adds signingKeyPath parameter and passes it to MSBuild to ensure analyzer step maintains signing |
| compound-build-akv-step.yml | Parameterizes signing key path and adds temporary diagnostic file copying |
| build-akv-official-job.yml | Passes signing key path parameter to both build and analyzer steps |
... thought I removed that already 🤦♂️
cheenamalhotra
previously approved these changes
Aug 19, 2025
samsharma2700
previously approved these changes
Aug 19, 2025
|
Reminder to also update AKV NuGet package version alongside. |
benrr101
dismissed stale reviews from samsharma2700 and cheenamalhotra
via
4a6e656
cheenamalhotra
approved these changes
Aug 19, 2025
samsharma2700
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing a high-priority issue where official builds of AKV provider are not strong name signed. This was a mistake in the new official pipeline, where the signing key path was not being provided to the Roslyn analyzer step of the official build job. Because the Roslyn analyzer step rebuilds the project (and replaces the build output), if this step does not perform signing, it will replace the strong name signed binaries with unsigned binaries.
This PR fixes this by 1) adding the signing key path variable to the Roslyn analyzer build arguments, and 2) factors out the signing key path to an argument to the main build and Roslyn analyzer steps.
Issues
Not sure if there is an issue that can be linked. But there's definitely an IcM about it.
Testing
See this build: https://sqlclientdrivers.visualstudio.com/ADO.Net/_build/results?buildId=123216&view=results
CI will still need to pass since it tweaks the signing behavior on non-official builds.