-
Notifications
You must be signed in to change notification settings - Fork 321
[6.1] Enable vector tests and validate ref assembly for vector APIs #3592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR ports changes from #3559 to the release/6.1 branch, enabling Vector and JSON tests for Azure SQL Server. The changes update test conditions to use IsAzureServer instead of specific feature flags and remove the deprecated IsJsonSupported configuration option.
Key changes include:
- Removal of the
IsJsonSupportedconfiguration property and its usage - Updated test conditional attributes from feature-specific checks to Azure server checks
- Code cleanup and organization improvements in Vector API validation tests
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| config.default.json | Removes deprecated IsJsonSupported configuration property |
| Config.cs | Removes IsJsonSupported field from configuration class |
| VectorTypeBackwardCompatibilityTests.cs | Updates test conditions from IsVectorSupported to IsAzureServer |
| VectorAPIValidationTest.cs | Refactors single large test into multiple focused test methods |
| NativeVectorFloat32Tests.cs | Updates test conditions from IsVectorSupported to IsAzureServer |
| JsonTest.cs | Updates test conditions from IsJsonSupported to IsAzureServer |
| JsonStreamTest.cs | Updates test conditions and reduces test data size for performance |
| JsonBulkCopyTest.cs | Updates test conditions and improves table name generation |
| DataTestUtility.cs | Removes deprecated vector/JSON support flags and adds IsAzureServer method |
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonStreamTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/JsonTest/JsonBulkCopyTest.cs
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3592 +/- ##
===============================================
- Coverage 69.69% 65.02% -4.68%
===============================================
Files 281 279 -2
Lines 62413 61748 -665
===============================================
- Hits 43500 40151 -3349
- Misses 18913 21597 +2684
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
This PR ports #3559 to release/6.1
Subset of changes were already present in 6.1 branch, so this is a manual port.
Testing
Enabled Vector and JSON tests.
Guidelines
Please review the contribution guidelines before submitting a pull request: