[6.1] Cleanup semaphore holder #3664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors semaphore handling in the WaitHandleDbConnectionPool by removing the SemaphoreHolder helper class and implementing direct try/finally patterns for semaphore acquisition and release.
- Removes the SemaphoreHolder helper class that was previously used for RAII-style semaphore management
- Replaces
using SemaphoreHolderstatements with explicit try/finally blocks for semaphore handling - Maintains the same semaphore acquisition and release logic but with more explicit control flow
...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs
Show resolved
Hide resolved
cheenamalhotra
commented
Oct 6, 2025
...oft.Data.SqlClient/src/Microsoft/Data/SqlClient/ConnectionPool/WaitHandleDbConnectionPool.cs
Show resolved
Hide resolved
mdaigle
previously approved these changes
Oct 6, 2025
benrr101
previously approved these changes
Oct 6, 2025
samsharma2700
previously approved these changes
Oct 6, 2025
cheenamalhotra
dismissed stale reviews from samsharma2700, benrr101, and mdaigle
via
c744b4d
mdaigle
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional change to #3653
Managing Semaphores with Disposable pattern may not be a good idea for .NET Framework applications (within CER enabled blocks). Reverting this change, to prevent any side effects.