Deprecate Active Directory Password authentication method #3671
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the Active Directory Password authentication method by adding the [Obsolete] attribute to SqlAuthenticationMethod.ActiveDirectoryPassword and adding pragma warnings to suppress obsolete member usage warnings throughout the codebase.
- Marks
ActiveDirectoryPasswordenum value as obsolete with informative message - Adds pragma warning suppressions around all existing usages of the deprecated method
- Updates both .NET Framework and .NET Core reference assemblies
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| TdsEnums.cs | Added [Obsolete] attribute to ActiveDirectoryPassword enum value |
| netfx/ref/Microsoft.Data.SqlClient.cs | Added [Obsolete] attribute to ActiveDirectoryPassword in .NET Framework reference assembly |
| netcore/ref/Microsoft.Data.SqlClient.cs | Added [Obsolete] attribute to ActiveDirectoryPassword in .NET Core reference assembly |
| SqlAuthenticationProviderManager.cs | Added [Obsolete] attribute to constant and pragma warnings around usage |
| ActiveDirectoryAuthenticationProvider.cs | Added pragma warnings around ActiveDirectoryPassword usage and fixed formatting |
| TdsParser.cs | Added pragma warnings around ActiveDirectoryPassword usage |
| SqlConnection.cs | Added pragma warnings around ActiveDirectoryPassword usage |
| SqlInternalConnectionTds.cs (both netfx/netcore) | Added pragma warnings around ActiveDirectoryPassword usage |
| AADConnectionTest.cs | Added pragma warnings around test code using ActiveDirectoryPassword |
| SqlAuthenticationProviderTest.cs | Added pragma warnings around test data using ActiveDirectoryPassword |
| SqlClientStressFactory.cs | Changed authentication method from ActiveDirectoryPassword to ActiveDirectoryIntegrated with pragma warnings |
src/Microsoft.Data.SqlClient/tests/StressTests/SqlClient.Stress.Tests/SqlClientStressFactory.cs
Outdated
Show resolved
Hide resolved
...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…veDirectoryAuthenticationProvider.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3188