Fix for decimal conversion overflow bug #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When mapping data from SQL Decimal(38,15) to .net decimal, this driver is throwing Conversion Overflow exception. Bug is already tracked under dotnet#95. This fix tries to alter this functionality, by rounding to nearest allowable decimal value.
|
This introduces a silent possible loss of precision. |
|
This solution solves some issues, though, we will miss the precise value. For instance, 978123.4139989546_6619485619_32681216 will convert to 978123.4139989546_6619485619_33; as you can see we lost 6 last digits and 2 has rounded to 3. |
|
I'll close this PR for now, due to data loss possibilities as captured by @Wraith2 and @DavoudEshtehari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mapping data from SQL Decimal(38,15) to .net decimal, this driver is throwing Conversion Overflow exception. Bug is already tracked under #95.
This fix tries to alter this functionality, by rounding to nearest allowable decimal value.