Move AAD/Entra Authentication into new Azure package #3680

paulmedynski · 2025-10-10T14:07:51Z

Overview

This PR contains changes to move the ActiveDirectoryAuthenticationProvider out of the MDS package and into the new Azure package. Please refer to the design here:

MDS Azure Extension Design

This PR is only concerned with moving the provider code out of MDS and creating the necessary base classes and types in the Abstractions package, which includes:

Creation of base classes/types in Abstractions related to the SQL authentication provider APIs.
Move of the ActiveDirectoryAuthenticationProvider.cs file into the Azure package.
Creation of the Azure package and related PR/CI pipelines.
Targeted updates/improvements due to blast radius/fallout of the above.

Future PRs will address:

Proper documentation (API, samples, reference).
Dependency updates.
Terminology modernization.
String localization.
Code refactoring/improvements.
Addition of a synchronous AcquireToken() method.
Separation of existing tests out of the MDS project and into the Azure project.
Addition of unit tests and improved integration tests.
New tests in the MDS project to confirm the authentication provider management logic.
Any additional issues we come up with that aren't directly related to the move.

This builds on the previous 2 PRs:

Testing

All existing tests in the MDS project are passing. This confirms that the move didn't break anything that is currently being tested.

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs

paulmedynski

Commentary for reviewers and some TODOs for me.

paulmedynski · 2025-10-10T17:33:05Z

eng/pipelines/common/templates/jobs/validate-signed-package-job.yml

      Get-ChildItem *.dll -Path $(extractedNugetPath)  -Recurse | ForEach-Object VersionInfo | Format-List
    displayName: 'Verify "File Version" matches expected values for DLLs'

-  - powershell: |


I removed the TestMicrosoftDataSqlClientVersion build property entirely. It was made redundant by MdsPackageVersion.

paulmedynski · 2025-10-10T17:38:06Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj

    <FileVersion>$(AbstractionsAssemblyFileVersion)</FileVersion>
    <Version>$(AbstractionsPackageVersion)</Version>
+
+    <DocumentationFile>$(Artifacts)/doc/$(TargetFramework)/$(AssemblyName).xml</DocumentationFile>


I will figure out where to put the XML docs in a later PR. For now, they go somewhere ignored by git.

paulmedynski · 2025-10-10T17:38:59Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationMethod.cs

This enum was moved out of TdsEnums.cs as-is.

paulmedynski · 2025-10-10T17:39:43Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationParameters.cs

+namespace Microsoft.Data.SqlClient;
+
+/// <include file='../doc/SqlAuthenticationParameters.xml' path='docs/members[@name="SqlAuthenticationParameters"]/SqlAuthenticationParameters/*'/>
+public sealed class SqlAuthenticationParameters


This and the token class are sealed. There is no need for an app to derive from them.

paulmedynski · 2025-10-10T17:40:50Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationToken.cs

+        string accessToken,
+        DateTimeOffset expiresOn)
+    {
+        if (string.IsNullOrEmpty(accessToken))


A null or empty token is meaningless, so I moved this policy decision out of MDS and into Abstractions. I think this is correct.

If you move it out, you need to localize the exception message...

Will be localized in a future PR.

...ta.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationTimeoutRetryHelper.cs

paulmedynski · 2025-10-10T17:53:17Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationParametersBuilder.cs

This is what remained in MDS from the SqlAuthenticationParamaters implementation.

paulmedynski · 2025-10-10T17:54:56Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

+using System.IO;
+using System.Reflection;
+
+#nullable enable


You will see some new ? and null checks below related to this.

paulmedynski · 2025-10-10T17:56:39Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs

+        /// <summary>
+        /// Convert from a SqlAuthenticationToken.
+        /// </summary>
+        internal SqlFedAuthToken(SqlAuthenticationToken token)


Moved from SqlAuthenticationToken, since conversion to a SqlFedAuthToken belongs here anyway.

paulmedynski · 2025-10-10T17:59:17Z

tools/targets/GenerateThisAssemblyCs.targets

+      $(ThisAssemblyClsCompliant) is false.
+    -->
+    <ThisAssemblyClsCompliantContent Condition="'$(ThisAssemblyClsCompliant)' != 'false'">
+[assembly: System.CLSCompliant(true)]


These new config properties are necessary to avoid collisions now that MDS depends on Abstractions.

paulmedynski

Commentary for reviewers.

paulmedynski · 2025-10-11T12:16:47Z

doc/snippets/Microsoft.Data.SqlClient/SqlAuthenticationProviderManager.xml

I decided to see how things look if we move GetProvider() and SetProvider() from SqlAuthenticationProvider to SqlAuthenticationProviderManager. This is a breaking change, but it separates the provider API definition from the act of managing providers. It was a mistake to combine these two into the provider API originally. I feel liks this is a worthwhile breaking change, and it will only affect apps that were managing providers explicitly via the get/set methods.

If we don't like this change, I can easily revert since it is all in a single commit.

In my opinion the API split itself makes sense (provided the breaking change is acceptable.) The class itself is currently halfway between being a completely static class and a class with a singleton instance, and if it's going to be exposed then I think it'd be best to settle on one approach or the other.

I've got one or two other comments, but they're not central to the public API; it's up to you whether they get pushed out to a later preview.

AuthenticationEnumFromString overlaps with SqlConnectionStringBuilder's parsing logic, and if the constants line up then we might be able to simplify by using that instead.

SetProvider currently iterates over a HashSet to perform a search for the authentication method; it can just use Contains instead.

This will be of lot of impact and will break many customers on upgrade as most customers use this API to register custom provider, I would say we keep it as-is for now if its not necessarily needed.

We need to keep the API impact nil for the Azure Split work, only library inclusion should be needed.

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs

codecov · 2025-10-20T14:03:02Z

Codecov Report

❌ Patch coverage is 77.77778% with 54 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/azure-split@287309f). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...Data/SqlClient/SqlAuthenticationProviderManager.cs	78.72%	20 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs	61.76%	13 Missing ⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs	61.76%	13 Missing ⚠️
...ta/SqlClient/SqlAuthenticationParametersBuilder.cs	79.41%	7 Missing ⚠️
...Microsoft/Data/SqlClient/TdsParserHelperClasses.cs	95.45%	1 Missing ⚠️

Additional details and impacted files

@@                 Coverage Diff                 @@
##             feat/azure-split    #3680   +/-   ##
===================================================
  Coverage                    ?   76.77%           
===================================================
  Files                       ?      269           
  Lines                       ?    45029           
  Branches                    ?        0           
===================================================
  Hits                        ?    34573           
  Misses                      ?    10456           
  Partials                    ?        0

Flag	Coverage Δ
addons	`90.82% <ø> (?)`
netcore	`76.67% <75.11%> (?)`
netfx	`76.15% <80.38%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- Removed addition of PDBs from <AllowedOutputExtensionsInPackageBuildOutputFolder>. - Removed MDS package ref dependency on Abstractions until pipelines are ready. - Renamed AbstractionsPackage to Abstractions in targets. - Updated BUILDGUIDE based on project ref behaviour. - Added feature branches to CI pipeline triggers. - Added missing/incomplete paths to the trigger. - Added dev/* branches to the CI triggers so PRs that target other dev/ branches can run CI. - Added missing MdsPackageVersion property to signed build pipeline job. - Commented-out failing NuGet tool installer task. - Re-ordered Guardian analysis step _before_ build step to avoid clobbering versioned DLLs. - Added MDS package version to AKV build/package steps. - Restored AKV nuspec ReferenceType property for AKV Official builds. - Explicitly building tooling before analysis. - Fixing validation steps to match XML props files. - Added PR automation triggers, and documented other pipeline sections. - Added ReferenceType throughout the MDS/AKV CI build steps. - Added NuGet.config update to main CI build step for Package reference mode. - Swapped Abstractions download and NuGet.config update to ensure packages/ exists before attempting to re-configure NuGet. - Clean target no longer removes packages/ - Uncommented package refs to Abstractions. - Added separate MDS and AKV project builds to support Package mode. - Added $ReferenceType$ property to MDS .nuspec like it is for AKV. - Removed obsolete version variables from merge conflict. - Adding $ReferenceType$ back to AKV nuspec. - Moved SqlAuthenticationProvider and friends into Abstractions. - Moved ActiveDirectoryAuthenticationProvider into a new Azure package. - Moved a bunch of docs into Abstractions and Azure projects. - Updated Abstractions classes to be abstract with minimal implementation. - Added back the implementations to MDS. - Re-worked some of the docs. - SqlAuthentication* classes separated out into Base classes in Abstractions. - Updated docs accordingly. - MDS compiles. - Some Azure package code moved, but not compiling. - Added an exception class for authentication errors. - Enabled XML doc compilation and validation. - Updated MDS to handle SqlAuthenticationProviderException instead of MSAL exceptions. - Removed Azure.Identity from MDS. - Got existing tests compiling using the new Azure package. - Added Azure package build targets. - Updated docs related to ReferenceType - Got all projects properly adhering to Package reference type. - Removed TestMicrosoftDataSqlClientVersion in favour of MdsPackageVersion. - Fixed tools restore from build.proj. - Fixed missing using for dummy auth provider. - Fixed obsolete warnings for password auth. - Moved SqlAuthenticationParameters entirely into Abstractions, avoiding an empty base class. - Moved SqlAuthenticationToken entirely into Abstractions. - Moved SqlAuthenticationProvider entirely into Abstractions. - Removed SqlAuthenticationProviderBase. - Exposed SqlAuthenticationProviderManager as a public API in MDS. - Moved SetProvider() and GetProvider() to the Manager where they should have been all along (Breaking Change). - Added catch-all exception handlers in prep for proper analysis and specific exception handling. - Some improvements to avoid meaningless nulls. - Added PR/CI pipeline support for the Azure package. - Fixed Abstractions download path. - Updated SqlAuthenticationProviderException to use Method instead of Action. - Fixed NRE in SqlException. - Fixed SqlAuthenticationProviderException use in MDS. - Added chaining Add() to SqlErrorCollection. - Added a useful message when _fedAuthToken is null after attempting to acquire a token. - Fixed auth provider error handling to mimic the old code. - Removing unnecessary database checks that are hanging forever. - Fixed timestamp truncation from long to uint causing cached tokens to be erroneously expired.

paulmedynski

Commentary for reviewers, and a few things for me to fix.

paulmedynski · 2025-10-20T15:05:24Z

eng/pipelines/common/templates/steps/build-all-tests-step.yml

      platform: '${{parameters.platform }}'
      configuration: '${{parameters.configuration }}'
-      msbuildArguments: '-t:BuildTestsNetFx -p:TF=${{parameters.targetFramework }} -p:TestSet=${{parameters.testSet }} -p:ReferenceType=${{parameters.referenceType }} -p:TestMicrosoftDataSqlClientVersion=${{parameters.mdsPackageVersion }} -p:AbstractionsPackageVersion=${{ parameters.abstractionsPackageVersion }}'
+      msbuildArguments: '-t:BuildTestsNetFx -p:TF=${{parameters.targetFramework }} -p:TestSet=${{parameters.testSet }} -p:ReferenceType=${{parameters.referenceType }} -p:MdsPackageVersion=${{parameters.mdsPackageVersion }} -p:AbstractionsPackageVersion=${{ parameters.abstractionsPackageVersion }} -p:AzurePackageVersion=${{ parameters.azurePackageVersion }}'


For now, the existing tests for AAD/Entra auth will remain within the MDS tests, so they need to depend on the new Azure package where the code was moved.

In a future PR, these tests will move over to the Azure package, and none of the MDS tests will depend on the Azure package.

paulmedynski · 2025-10-20T15:08:16Z

eng/pipelines/jobs/pack-azure-package-ci-job.yml

+            targetPath: $(Build.SourcesDirectory)/packages
+
+        # Use the local NuGet.config that references the packages/ directory.
+        - pwsh: cp $(Build.SourcesDirectory)/NuGet.config.local $(Build.SourcesDirectory)/NuGet.config


This is much simpler than what the existing pipelines do to parse the JSON, update it, and then write it back out via PowerShell foo. We should use this approach when we develop the new pipelines.

paulmedynski · 2025-10-20T15:12:58Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/doc/SqlAuthenticationProviderException.xml

Docs for the Abstractions and Azure packages are still considered works in progress. There will be future PRs that provide complete documentation.

...rosoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationProviderExceptionTest.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationTokenTest.cs

paulmedynski · 2025-10-20T15:43:26Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs

-        private static void SetDefaultAuthProviders(SqlAuthenticationProviderManager instance)
-        {
-            if (instance != null)
+            // If our Azure extensions package is present, use its


This is the new logic that looks for the Azure package assembly and loads the AAD Auth class from it.

paulmedynski · 2025-10-20T15:49:03Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlException.cs


        internal static SqlException CreateException(SqlErrorCollection errorCollection, string serverVersion, Guid conId, Exception innerException = null, SqlBatchCommand batchCommand = null)
        {
-            Debug.Assert(errorCollection != null && errorCollection.Count > 0, "no errorCollection?");


Don't use debug asserts to check pre-conditions!

paulmedynski · 2025-10-20T15:49:52Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlUtil.cs

            return exc;
        }

-        internal static Exception Azure_ManagedIdentityException(string msg)


This was unused before any of these changes. I removed it to avoid future confusion.

paulmedynski · 2025-10-20T15:51:29Z

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs

    {
-        internal string spn;
-        internal string stsurl;
+        internal string Spn { get; }


These fields are now immutable, which provides a stronger class invariant. Same changes to SqlFedAuthToken below.

paulmedynski · 2025-10-20T15:53:30Z

...rosoft.Data.SqlClient/tests/ManualTests/SQL/DataClassificationTest/DataClassificationTest.cs

                try
                {
                    sqlConnection.Open();
-                    Assert.True(DataTestUtility.IsSupportedDataClassification());


This is already checked by the [ConditionalFact] above.

mdaigle · 2025-10-20T17:02:35Z

src/Directory.Packages.props

+  <!-- Azure Dependencies -->
+
+  <ItemGroup>
+    <PackageVersion Include="Azure.Identity" Version="1.14.2" />


Is there a reason not to use the latest version (1.17.0)?

src/Microsoft.Data.SqlClient.Extensions/Azure/src/AuthenticationException.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

...crosoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Azure/src/Azure.csproj

David-Engel

Partial 45/89 review

David-Engel · 2025-10-20T16:36:01Z

eng/pipelines/stages/build-azure-package-ci-stage.yml

+          buildConfiguration: ${{ parameters.buildConfiguration }}
+          displayNamePrefix: Win
+          jobNameSuffix: windows
+          netFrameworkRuntimes: [net462, net47, net471, net472, net48, net481]


Do we really need to test all those combinations? Don't other jobs just target the lowest version we support?

David-Engel · 2025-10-20T16:42:40Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/doc/SqlAuthenticationProvider.xml

    <AcquireTokenAsync>
-      <param name="parameters">The Active Directory authentication parameters passed by the driver to authentication providers.</param>
      <summary>Acquires a security token from the authority.</summary>
+      <param name="parameters">The Active Directory authentication parameters passed by the driver to authentication providers.</param>


Perfect opportunity to fix this name (Azure AD to Entra ID rebranding a few years ago). In fact, I don't think we even need the second-fourth words:

Suggested change

<param name="parameters">The Active Directory authentication parameters passed by the driver to authentication providers.</param>

<param name="parameters">The parameters passed by the driver to authentication providers.</param>

David-Engel · 2025-10-20T16:55:04Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/doc/SqlAuthenticationParameters.xml

-      <summary>
-        Initializes a new instance of the <see cref="T:Microsoft.Data.SqlClient.SqlAuthenticationParameters" /> class using the specified authentication method, server name, database name, resource URI, authority URI, user login name/ID, user password, connection ID and connection timeout value.
-      </summary>
+      <param name="connectionTimeout">The connection timeout, in seconds.</param>


This has always bothered me. This should be the timeout for the authentication step within the overall connection establishment. We might even be within a command timeout during an idle connection recovery event. Calling it "connection timeout" seems inaccurate. I think "authentication timeout" would be better.

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.cs

David-Engel · 2025-10-20T17:41:18Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationToken.cs

+        string accessToken,
+        DateTimeOffset expiresOn)
+    {
+        if (string.IsNullOrEmpty(accessToken))


If you move it out, you need to localize the exception message...

David-Engel · 2025-10-20T17:43:10Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationMethodTest.cs

@@ -0,0 +1,34 @@
+namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;


Missing license header

David-Engel · 2025-10-20T17:43:24Z

src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationParametersTest.cs

@@ -0,0 +1,78 @@
+namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;


Missing license header

David-Engel · 2025-10-20T17:43:36Z

...rosoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationProviderExceptionTest.cs

@@ -0,0 +1,117 @@
+namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;


Missing license header

src/Microsoft.Data.SqlClient.Extensions/Azure/src/AuthenticationException.cs

David-Engel · 2025-10-20T17:46:45Z

src/Microsoft.Data.SqlClient.Extensions/Azure/test/Azure.Test.csproj

+<Project Sdk="Microsoft.NET.Sdk">
+
+  <PropertyGroup>
+    <TargetFrameworks>net462;net47;net471;net472;net48;net481;net8.0;net9.0</TargetFrameworks>


I think we really only need net462...

…r to maintain API for now. - Addressed review comments.

- Added some config improvements to xUnit runners.

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationParameters.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs

src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationProviderTest.cs

…qlClient-Package runs.

…eaved output.

…g interleaved output." This reverts commit 807bfa7.

…ith CI-SqlClient-Package runs." This reverts commit d4c681a.

- Reverted SqlAuthenticationParameters authenticationTimeout constructor argument to its original name connectionTimeout and added docs explaining why.

cheenamalhotra · 2025-10-23T16:09:42Z

doc/snippets/Microsoft.Data.SqlClient/SqlAuthenticationProviderManager.xml

This will be of lot of impact and will break many customers on upgrade as most customers use this API to register custom provider, I would say we keep it as-is for now if its not necessarily needed.

We need to keep the API impact nil for the Azure Split work, only library inclusion should be needed.

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationParameters.cs

- Moved some tests around to get access to internals and to compile everywhere.

paulmedynski

I reverted all of the previous public API changes and left notes about what we may want to bring back in the future.

paulmedynski · 2025-10-28T12:01:09Z

src/Microsoft.Data.SqlClient/tests/FunctionalTests/AADAuthenticationTests.cs

+        /// that configuration source.
        /// </summary>
-        [Fact]
+        [ConditionalFact(typeof(TestUtility), nameof(TestUtility.IsNetFramework))]


Prefer conditional execution to conditional compilation.

paulmedynski · 2025-10-28T12:01:39Z

src/Microsoft.Data.SqlClient/tests/FunctionalTests/AADAuthenticationTests.cs

-        // This tests the dynamic assembly loading code in the Abstractions
-        // package.
-        [Fact]
-        public void Abstractions_And_Manager_GetSetProvider_Equivalent()


I moved this to the UnitTests project for easy access to the Manager internals.

src/Microsoft.Data.SqlClient/tests/FunctionalTests/DataCommon/TestUtility.cs

mdaigle · 2025-10-29T20:46:15Z

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlInternalConnectionTds.cs

                }
-                // Deal with Msal service exceptions first, retry if 429 received.
-                catch (MsalServiceException serviceException)
+                catch (SqlAuthenticationProviderException ex)


I'm mainly seeing differences in the inner exception, but it looks like the outer exceptions that are ultimately thrown should be the same.

edwardneal reviewed Oct 10, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs Outdated Show resolved Hide resolved

paulmedynski commented Oct 10, 2025

View reviewed changes

paulmedynski commented Oct 11, 2025

View reviewed changes

Base automatically changed from dev/paul/azure-split/abstractions-pipelines to feat/azure-split October 16, 2025 16:23

paulmedynski force-pushed the dev/paul/azure-split/authentication branch from ddc22a7 to 71fd319 Compare October 16, 2025 19:57

paulmedynski force-pushed the feat/azure-split branch from a60a025 to 7f88ea6 Compare October 16, 2025 19:57

paulmedynski force-pushed the dev/paul/azure-split/authentication branch from 71fd319 to 283f241 Compare October 16, 2025 20:04

ErikEJ reviewed Oct 20, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserHelperClasses.cs Show resolved Hide resolved

paulmedynski added 2 commits October 20, 2025 11:59

Abstractions Package - C# project changes (#3626)

f6a74cc

Abstractions Package - Pipeline Changes (#3628)

c66066a

paulmedynski force-pushed the feat/azure-split branch from 7f88ea6 to c66066a Compare October 20, 2025 14:59

paulmedynski force-pushed the dev/paul/azure-split/authentication branch from 87be738 to 224a316 Compare October 20, 2025 15:00

paulmedynski commented Oct 20, 2025

View reviewed changes

paulmedynski marked this pull request as ready for review October 20, 2025 15:58

paulmedynski requested a review from a team as a code owner October 20, 2025 15:58

mdaigle reviewed Oct 20, 2025

View reviewed changes

David-Engel reviewed Oct 20, 2025

View reviewed changes

paulmedynski added 2 commits October 21, 2025 12:25

- Added obsolete Get/Set Provider methods on SqlAuthenticationProvide…

bdd1c13

…r to maintain API for now. - Addressed review comments.

- Fixed dummy auth provider tests on .NET Framework.

522e5a4

- Added some config improvements to xUnit runners.

paulmedynski commented Oct 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationParameters.cs Outdated Show resolved Hide resolved

paulmedynski commented Oct 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.cs Show resolved Hide resolved

paulmedynski commented Oct 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProviderInternal.cs Show resolved Hide resolved

paulmedynski commented Oct 21, 2025

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/SqlAuthenticationProviderTest.cs Outdated Show resolved Hide resolved

paulmedynski added this to the 7.0.0-preview3 milestone Oct 21, 2025

paulmedynski added 4 commits October 21, 2025 17:05

- Attempt to fix sensitive diagnostics tests having trouble with CI-S…

d4c681a

…qlClient-Package runs.

- Replaced Console output with xUnit output to avoid confusing interl…

807bfa7

…eaved output.

Revert "- Replaced Console output with xUnit output to avoid confusin…

39d2d10

…g interleaved output." This reverts commit 807bfa7.

Revert "- Attempt to fix sensitive diagnostics tests having trouble w…

278c872

…ith CI-SqlClient-Package runs." This reverts commit d4c681a.

paulmedynski force-pushed the feat/azure-split branch from c66066a to 287309f Compare October 23, 2025 13:04

paulmedynski added 3 commits October 23, 2025 10:18

Merge branch 'feat/azure-split' into dev/paul/azure-split/authentication

eebd756

- Addressed review comments.

5d5fa84

- Reverted SqlAuthenticationParameters authenticationTimeout constructor argument to its original name connectionTimeout and added docs explaining why.

- Fixed build error related to SqlAuthenticationParameters.

65091f4

paulmedynski requested review from David-Engel, mdaigle and saurabh500 October 23, 2025 16:28

cheenamalhotra requested changes Oct 24, 2025

View reviewed changes

cheenamalhotra reviewed Oct 24, 2025

View reviewed changes

src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationParameters.cs Outdated Show resolved Hide resolved

- Reverted all public API changes from previous commits.

323cdda

- Moved some tests around to get access to internals and to compile everywhere.

paulmedynski commented Oct 28, 2025

View reviewed changes

paulmedynski added 3 commits October 28, 2025 09:05

- Removed SqlAuthenticationProviderManager from ref projects.

196edf5

- Fixed incorrect checks for runtime detection.

a2988d3

- Fixed a few missed Manager provider calls.

48e5eb7

cheenamalhotra mentioned this pull request Oct 28, 2025

Feature: SqlAuthenticationProvider API change proposal #3728

Open

mdaigle reviewed Oct 28, 2025

View reviewed changes

src/Microsoft.Data.SqlClient/tests/FunctionalTests/DataCommon/TestUtility.cs Show resolved Hide resolved

paulmedynski requested review from cheenamalhotra and mdaigle October 29, 2025 10:21

mdaigle approved these changes Oct 29, 2025

View reviewed changes

	<param name="parameters">The Active Directory authentication parameters passed by the driver to authentication providers.</param>
	<param name="parameters">The parameters passed by the driver to authentication providers.</param>

		@@ -0,0 +1,34 @@
		namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;

		@@ -0,0 +1,78 @@
		namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;

		@@ -0,0 +1,117 @@
		namespace Microsoft.Data.SqlClient.Extensions.Abstractions.Test;

Move AAD/Entra Authentication into new Azure package #3680

Are you sure you want to change the base?

Move AAD/Entra Authentication into new Azure package #3680

Uh oh!

Conversation

paulmedynski commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Testing

Uh oh!

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

paulmedynski left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

paulmedynski commented Oct 10, 2025 •

edited

Loading

paulmedynski Oct 10, 2025 •

edited

Loading

codecov bot commented Oct 20, 2025 •

edited

Loading