Adding support for .NET 10

[priyankatiwari08]

Description

As part of adding support for .NET 10 below changes has been done:

1. Added conditional logic for PackageReference entries for assemblies which are now included in the .NET 10 Base Class Library. Without this change, keeping them caused runtime redundancy and potential NU1510 errors during SDK pruning:

   • Sytem.Text.Json
   • System.Text.Encodings.Web
   • System.Buffers
   • System.Memory
   • System.Runtime.InteropServices.RuntimeInformation

2. Enabled multi-targeting for .NET 10 in test projects to ensure compatibility and proper coverage.

Issues

#3576
Customer issue: #3522

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull Request Overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

[paulmedynski]

I think your best bet will be to update the pipelines to install the .NET 10 SDK (instead of .NET 9 SDK), and ensure that we use .NET 10 SDK to build and run the test projects.

The driver projects must remain using .NET 9 SDK to build.

Hmm... I don't think we can separate this out in our current pipelines. Let's just use the .NET 10 SDK for everything and see how it goes.

[paulmedynski]

So, making this change will require that we start using the .NET 10 SDK to build the tests everywhere (locally as devs and during all pipelines).

For devs, that's fine - we just need to install the .NET 10 SDK wherever we're developing. We will need to update the BUILDGUIDE.md to reflect this new requiremet.

For pipelines, we will need to find everywhere that we perform a build of the tests and add a step that installs the .NET 10 SDK. If you do this, then you can use the existing CI pipelines to verify .NET 10 compatibility rather than trying to get the tests to run for you locally (which is close to impossible currently).

[paulmedynski]

You could use $([MSBuild]::VersionGreaterThanOrEquals(...)) here and below.

[priyankatiwari08]

I made this change and tried building the driver code but it resulted in below error:

error MSB4184: The express
ion "[MSBuild]::VersionGreaterThanOrEquals('', net9.0)" cannot be evaluated. Version string was not in a correct format.

On checking further could understand that since we have multi-targetting with TargetFrameworks, MSBuild sets $(TargetFramework) for each target during the build, but during initial evaluation or restore, it may be unset leading to $TargetFramework being empty which caused above error.

Hence, I believe its rather safe to use below:

• It directly checks for the exact target frameworks you want (net9.0 or net10.0).
• It avoids MSBuild errors if $(TargetFramework) is empty or not a valid version string.
• It is more readable and less error-prone than using VersionGreaterThanOrEquals, which can fail if the property is not set.

[paulmedynski]

Have a look at the docs for VersionGreaterThanOrEquals here:

https://learn.microsoft.com/en-us/visualstudio/msbuild/property-functions?view=vs-2022#msbuild-version-comparison-functions

You could also try using IsTargetFrameworkCompatible:

https://learn.microsoft.com/en-us/visualstudio/msbuild/property-functions?view=vs-2022#msbuild-targetframework-and-targetplatform-functions

$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'net9.0'))

That should be false when $(TargetFramework) is net8.0, and true for net9.0 and net10.0.

I think that is actually better than using VersionGreaterThanOrEquals.

[mdaigle]

The driver projects must remain using .NET 9 SDK to build.

@paulmedynski I've been thinking about this. We can start publishing a .NET 10 dll with only a minor version bump. Maybe we target our spring 7.1 release for that addition. At that point it should be better supported in all the build tooling.

[priyankatiwari08]

/azp run

[azure-pipelines]

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

[dotnet-policy-service]

@priyankatiwari08 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@dotnet-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement ( “Agreement” ) is agreed to by the party signing below ( “You” ),
and conveys certain license rights to the .NET Foundation ( “.NET Foundation” ) for Your contributions to
.NET Foundation open source projects. This Agreement is effective as of the latest signature date below.

1. Definitions.

“Code” means the computer software code, whether in human-readable or machine-executable form,
that is delivered by You to .NET Foundation under this Agreement.

“Project” means any of the projects owned or managed by .NET Foundation and offered under a license
approved by the Open Source Initiative (www.opensource.org).

“Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
Project, including but not limited to communication on electronic mailing lists, source code control
systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
discussing and improving that Project, but excluding communication that is conspicuously marked or
otherwise designated in writing by You as “Not a Submission.”

“Submission” means the Code and any other copyrightable material Submitted by You, including any
associated comments and documentation.

2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
Project. This Agreement covers any and all Submissions that You, now or in the future (except as
described in Section 4 below), Submit to any Project.

3. Originality of Work. You represent that each of Your Submissions is entirely Your
original work. Should You wish to Submit materials that are not Your original work,
You may Submit them separately to the Project if You (a) retain all copyright and
license information that was in the materials as you received them, (b) in the
description accompanying your Submission, include the phrase "Submission
containing materials of a third party:" followed by the names of the third party and any
licenses or other restrictions of which You are aware, and (c) follow any other
instructions in the Project's written guidelines concerning Submissions.

4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
Submission is made in the course of Your work for an employer or Your employer has intellectual
property rights in Your Submission by contract or applicable law, You must secure permission from Your
employer to make the Submission before signing this Agreement. In that case, the term “You” in this
Agreement will refer to You and the employer collectively. If You change employers in the future and
desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
and secure permission from the new employer before Submitting those Submissions.

5. Licenses.

a. Copyright License. You grant .NET Foundation, and those who receive the Submission directly
or indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable
license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform,
and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing
rights to third parties.

b. Patent License. You grant .NET Foundation, and those who receive the Submission directly or
indirectly from .NET Foundation, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license
under Your patent claims that are necessarily infringed by the Submission or the combination of the
Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
import or otherwise dispose of the Submission alone or with the Project.

c. Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
granted by implication, exhaustion, estoppel or otherwise.

6. Representations and Warranties. You represent that You are legally entitled to grant the above
licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
have disclosed under Section 3 ). You represent that You have secured permission from Your employer to
make the Submission in cases where Your Submission is made in the course of Your work for Your
employer or Your employer has intellectual property rights in Your Submission by contract or applicable
law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
EXPRESSLY STATED IN SECTIONS 3, 4, AND 6 , THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.

7. Notice to .NET Foundation. You agree to notify .NET Foundation in writing of any facts or
circumstances of which You later become aware that would make Your representations in this
Agreement inaccurate in any respect.

8. Information about Submissions. You agree that contributions to Projects and information about
contributions may be maintained indefinitely and disclosed publicly, including Your name and other
information that You submit with Your Submission.

9. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
defenses of lack of personal jurisdiction and forum non-conveniens.

10. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
supersedes any and all prior agreements, understandings or communications, written or oral, between
the parties relating to the subject matter hereof. This Agreement may be assigned by .NET Foundation.

.NET Foundation dedicates this Contribution License Agreement to the public domain according to the Creative Commons CC0 1.

[Copilot]

Pull Request Overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/Directory.Packages.props:49

• The condition for Microsoft.Extensions.Hosting should be updated to include net10.0, similar to the other updated conditions in this file. Currently, net10.0 builds will fall into the 'not equal' condition on line 53, which may not be the intended behavior given the pattern established elsewhere in this file.

  <ItemGroup Condition="'$(TargetFramework)' == 'net9.0'">

[apoorvdeshmukh]

/azp run

[azure-pipelines]

Azure Pipelines failed to run 2 pipeline(s).

[priyankatiwari08]

/azp run

[azure-pipelines]

Azure Pipelines failed to run 2 pipeline(s).

[priyankatiwari08]

/azp run

[azure-pipelines]

Azure Pipelines failed to run 2 pipeline(s).

[paulmedynski]

It would also be nice to expirment with the workaround documented here to see if we can eliminate the ensure-dotnet-version.yml template:

microsoft/azure-pipelines-tasks#16501 (comment)

And the alternate way to determine architecture here:

microsoft/azure-pipelines-tasks#20300 (comment)

That would de-clutter the job steps that look like we're repeatedly trying to install SDKs and remove our PowerShell foo.

[paulmedynski]

Now that we're installing the .NET 10 SDK everywhere, we can change all of these .NET 9 installs to 'runtime'. We don't need the .NET 9 SDK for anything. Do this for the UseDotNet@2 tasks and calls to the ensure-dotnet-version.yml template.

[paulmedynski]

You can remove net9.0 here. This project builds a tool that we use during the build, so it only needs to target one runtime.

[paulmedynski]

Tidy up these commented-out lines.