-
Notifications
You must be signed in to change notification settings - Fork 321
Port #3857 to release/6.1 #3877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR ports a bug fix from PR #3857 to the release/6.1 branch, addressing issue #3845. The fix prevents a potential NullReferenceException when processing batch RPC commands with Always Encrypted enabled.
Changes:
- Added a null check for
systemParamsbefore accessing itsLengthproperty in theTryFetchInputParameterEncryptionInfomethod - Applied the fix consistently to both .NET Framework and .NET Core implementations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs |
Added null check before accessing systemParams.Length in batch RPC mode parameter encryption logic |
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlCommand.cs |
Added null check before accessing systemParams.Length in batch RPC mode parameter encryption logic |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/6.1 #3877 +/- ##
===============================================
- Coverage 65.42% 63.64% -1.79%
===============================================
Files 279 279
Lines 53302 53302
===============================================
- Hits 34875 33924 -951
- Misses 18427 19378 +951
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Port #3857 to release/6.1
Closes #3845
Issues
#3845
Testing
To be introduced when addressing #3876
Guidelines
Please review the contribution guidelines before submitting a pull request: