Skip to content

Comments

Backport 6.0 | Use global.json in all pipeline jobs (#3927)#3959

Merged
mdaigle merged 4 commits intorelease/6.0from
dev/paul/release/6.0/global-json
Feb 13, 2026
Merged

Backport 6.0 | Use global.json in all pipeline jobs (#3927)#3959
mdaigle merged 4 commits intorelease/6.0from
dev/paul/release/6.0/global-json

Conversation

@paulmedynski
Copy link
Contributor

@paulmedynski paulmedynski commented Feb 12, 2026

Description

Backport of #3927:

  • Added global.json to restrict our SDK to the single supported version, currently 9.0.311.

Testing

The CI pipelines will validate these changes.

@paulmedynski paulmedynski added the Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems. label Feb 12, 2026
Copilot AI review requested due to automatic review settings February 12, 2026 20:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Backport PR to standardize SDK selection across Azure DevOps pipelines by relying on global.json, introducing a shared install-dotnet pipeline template (including ARM64 handling), and updating related build/test pipeline templates and documentation accordingly.

Changes:

  • Update global.json SDK pinning and refactor pipeline jobs/templates to install SDK via useGlobalJson.
  • Add shared install-dotnet.yml template plus an ARM64 PowerShell installer workaround.
  • Refresh pipeline test matrices (TFMs / ARM64 flag propagation) and update repo docs/config formatting.

Reviewed changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/Microsoft.Data.SqlClient.sln Adds test project entries to the solution.
global.json Updates pinned SDK version and roll-forward settings; adds explanatory comments.
eng/pipelines/dotnet-sqlclient-ci-core.yml Expands test TFMs, adds ARM64 config flag, and gates enclave jobs on fork state.
eng/pipelines/common/templates/steps/prepare-test-db-step.yml Whitespace/formatting adjustment.
eng/pipelines/common/templates/steps/pre-build-step.yml Switches to shared install-dotnet template; keeps env/service prep.
eng/pipelines/common/templates/steps/install-dotnet.yml New shared template to install SDK (global.json) and requested runtimes.
eng/pipelines/common/templates/steps/install-dotnet-arm64.ps1 New ARM64 installer script used by install-dotnet.yml.
eng/pipelines/common/templates/steps/ci-project-build-step.yml Removes inline UseDotNet steps (assumes SDK installed earlier).
eng/pipelines/common/templates/steps/ci-prebuild-step.yml Simplifies prebuild behavior, mainly for package builds.
eng/pipelines/common/templates/steps/build-all-configurations-signed-dlls-step.yml Refactors signed build step to use shared SDK install.
eng/pipelines/common/templates/stages/ci-run-tests-stage.yml Wires through ARM64 flag to jobs.
eng/pipelines/common/templates/jobs/ci-run-tests-job.yml Installs SDK/runtimes per job (incl. ARM64/x86 paths) and tweaks job params.
eng/pipelines/common/templates/jobs/ci-code-coverage-job.yml Uses shared SDK install template; keeps coverage merge/report logic.
eng/pipelines/common/templates/jobs/ci-build-nugets-job.yml Installs SDK before building; adds extra Release compile on Debug runs.
README.md Updates links and reorganizes “Helpful Links” section.
BUILDGUIDE.md Adds .NET SDK requirements guidance and formatting fixes.
.editorconfig Minor whitespace fixes and adds formatting rules for bat/cmd/ps1.
.config/CredScanSuppressions.json Formatting-only changes.

Copilot AI review requested due to automatic review settings February 13, 2026 14:01
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 21 changed files in this pull request and generated no new comments.

@paulmedynski paulmedynski marked this pull request as ready for review February 13, 2026 15:33
@paulmedynski paulmedynski requested a review from a team as a code owner February 13, 2026 15:33
@paulmedynski paulmedynski changed the title Backport 6.1 | Use global.json in all pipeline jobs (#3927) Backport 6.0 | Use global.json in all pipeline jobs (#3927) Feb 13, 2026
@mdaigle mdaigle merged commit 45380dd into release/6.0 Feb 13, 2026
268 checks passed
@mdaigle mdaigle deleted the dev/paul/release/6.0/global-json branch February 13, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area\Engineering Use this for issues that are targeted for changes in the 'eng' folder or build systems.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants