Fix stored procedure issues introduced in v1.1.2 #544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
David-Engel,
karinazhou,
JRahnama and
DavoudEshtehari
src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
JRahnama
reviewed
Apr 27, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
Show resolved
Hide resolved
|
@cheenamalhotra Did you manually run the test in ManualTests\SQL\AsyncTest\AsyncCancelledConnectionsTest.cs to verify the original issue is still fixed? The test fails regularly in pipelines, so it is disabled by default. But it always worked well on my local machine. |
|
Yes I verified that test. Did you experience any issues with that one? |
|
Can the issue details in #542 be converted to a test to make sure this doesn't regress in future? |
karinazhou
reviewed
Apr 28, 2020
src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/SqlCommand/SqlCommandCancelTest.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #542
This PR revises fix introduced in #490 to address stored procedure concerns.
The check for
_attentionSentis applicable for both TDS Tokens DONEPROC and DONE, whereas, we only want to conditionally work when DONE_ATTN bit is received, which is validated whenHasReceivedAttentionis populated in the same flow.This seems like the right way to fix MARS TDS Header issue.