Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix | Fix SqlClientMetaDataCollectionNames.Parameters mismatching issue #580

Merged
merged 2 commits into from
Jun 10, 2020

Conversation

karinazhou
Copy link
Member

This is a fix for GH#575.

  • Change initial SqlClientMetaDataCollectionNames.Parameters to SqlClientMetaDataCollectionNames.ProcedureParameters.
  • Add test cases for this.

@cheenamalhotra cheenamalhotra added this to the 2.0.0 milestone May 27, 2020
@cheenamalhotra cheenamalhotra added 🆕 Public API Issues/PRs that introduce new APIs to the driver. 🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver. labels Jun 2, 2020
@johnnypham johnnypham self-requested a review June 8, 2020 23:42
@cheenamalhotra cheenamalhotra merged commit 4258e4b into dotnet:master Jun 10, 2020
karinazhou added a commit to karinazhou/SqlClient that referenced this pull request Jun 10, 2020
…ue (dotnet#580)

* Fix Parameters undefined issue and add test case

* Update valid names and add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Breaking Change Issues/PRs that are related with breaking API changes in the driver. 🆕 Public API Issues/PRs that introduce new APIs to the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants