Fix SqlSequentialStream multipacket reads stalling and add covering test #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Wraith2 This looks like a workaround but not the real issue fix. We should investigate when this issue was introduced in NetCore and fix the real problem when it was introduced. |
|
The async changes I've made aren't in the fx codebase and they are what will have introduced the issue so I'm not surprised that it isn't reproducible on fx. It is intended to be the correct fix and not a workaround though. I debugged through for a quite a while and I was satisfied that there wasn't a huge underlying problem but that it was due to the changes from async captures to using a state object. |
|
It'll have been introduced in #328 |
|
We'll take it in for GA. |
|
Excellent thanks. |
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #600
When I reworked async infrastructure a couple of subtle errors crept in and because there was no covering test weren't visible. This corrects the problem and adds a test.
@cheenamalhotra @David-Engel I'd suggest that this go into 2.0.0 release.