Fix | Fix serialization issue with SqlException (.NET Core) #780
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
David-Engel,
DavoudEshtehari,
JRahnama,
johnnypham and
karinazhou
cheenamalhotra
force-pushed
the
fix778
branch
from
3753e87 to
2b08520
Compare
David-Engel
approved these changes
Nov 2, 2020
JRahnama
reviewed
Nov 3, 2020
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SqlException.cs
Show resolved
Hide resolved
JRahnama
approved these changes
Nov 3, 2020
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #778
Reported issue #778 is not reproducible with any other SqlClient driver except Microsoft.Data.SqlClient (.NET Core - all versions).
Apparently the
System.Runtime.CompilerServices.TypeForwardedFromtag is the cause of this issue.Removing this tag fixes the issue.
Test added.