Fix missing error messages in Managed SNI #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
requested review from
JRahnama,
karinazhou,
DavoudEshtehari,
johnnypham and
David-Engel
cheenamalhotra
added
the
Area\Managed SNI
cheenamalhotra
force-pushed
the
fixSNIErrors
branch
from
97b9aa2
to
88dd85a
Compare
cheenamalhotra
force-pushed
the
fixSNIErrors
branch
from
88dd85a
to
6eacc9d
Compare
karinazhou
reviewed
Jan 15, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs
Show resolved
Hide resolved
karinazhou
reviewed
Jan 15, 2021
src/Microsoft.Data.SqlClient/netcore/src/Resources/Strings.resx
Outdated
Show resolved
Hide resolved
karinazhou
reviewed
Jan 15, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs
Outdated
Show resolved
Hide resolved
cheenamalhotra
force-pushed
the
fixSNIErrors
branch
from
873f32e
to
2369047
Compare
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/LocalDB.Windows.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/SNINpHandle.cs
Show resolved
Hide resolved
JRahnama
reviewed
Jan 18, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/LocalDB.Windows.cs
Show resolved
Hide resolved
karinazhou
approved these changes
Jan 18, 2021
DavoudEshtehari
approved these changes
Jan 18, 2021
johnnypham
reviewed
Jan 18, 2021
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/SNI/LocalDB.Windows.cs
Show resolved
Hide resolved
JRahnama
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these error messages not included in exceptions while working on Managed SNI.
With these changes, empty messages will not be thrown and error codes shall correspond to message text.