Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SniProxy is used as a single instance and called like this:
This involves calling the GetInstance() method to get the single instance and then calling a function on that instance which only uses the parameters that are passed in. In these cases the functions could be static or merged into the callsite if there is only one use of the function.
The only thing that can't be removed from this single instance pattern is the GetLastError functions. I've investigated what it would take to remove it and it's very very complicated and involves significant changes to the StateObject interface between shared and platform implementations. I choose not to do that now.