Fast TensorAccessor #1396
Open
Fast TensorAccessor #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haytham2597
commented
Nov 3, 2024
test/TorchSharpTest/TestJIT.cs
Outdated
There was a problem hiding this comment.
For some reason sometime the test failed or success about TestLoadJIT_3() i noticed that the values is still so closest with so small difference so i put threshold.
haytham2597
commented
Nov 3, 2024
| var tt = tensor(v, t.shape, t.dtype); | ||
| Assert.Equal(0, t.storage_offset()); | ||
| Assert.True(tt.equal(t).all().item<bool>()); | ||
| } |
There was a problem hiding this comment.
I need add more test like for example ToArray(18, 4) that is from index 18 with length 4. Or add ToArray(5) mean from index 5 to the numel. And some of CopyFrom, ToNDArray, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.