Skip to content

Restore QueryProductDetailsResult and fix QueryProductDetailsAsync behavior #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Restore QueryProductDetailsResult and fix QueryProductDetailsAsync behavior #1207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2495de6
Initial plan
Copilot Jul 15, 2025
efe73aa
Restore QueryProductDetailsResult and fix QueryProductDetailsAsync be…
Copilot Jul 15, 2025
265625c
Add partial modifier to QueryProductDetailsResult and fix interface i…
Copilot Jul 15, 2025
4e939c7
Revert commit 265625c and add partial modifier to QueryProductDetails…
Copilot Jul 16, 2025
d1de5f6
Fix QueryProductDetailsResult partial class and interface implementation
Copilot Jul 16, 2025
475b91a
Revert "Fix QueryProductDetailsResult partial class and interface imp…
jonathanpeppers Jul 16, 2025
e758a44
Restore a small piece of d1de5f6abd286e02c6581b1264ad914b7ff15a40
jonathanpeppers Jul 16, 2025
e0864f2
This implementation is even cleaner
jonathanpeppers Jul 16, 2025
7bab16f
Smaller diff
jonathanpeppers Jul 16, 2025
3b68558
Update Additions.cs
jonathanpeppers Jul 16, 2025
96fd2ea
Update Additions.cs
jonathanpeppers Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2167,7 +2167,7 @@
"groupId": "com.android.billingclient",
"artifactId": "billing",
"version": "8.0.0",
"nugetVersion": "8.0.0",
"nugetVersion": "8.0.0.1",
"nugetId": "Xamarin.Android.Google.BillingClient",
"type": "xbd"
},
Expand Down
20 changes: 19 additions & 1 deletion source/com.android.billingclient/billing/Additions/Additions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,20 @@ public class QuerySkuDetailsResult
public IList<SkuDetails> SkuDetails { get; set; }
}

public partial class QueryProductDetailsResult
{
public QueryProductDetailsResult() { }

public BillingResult Result { get; set; }

[Obsolete ($"Use {nameof(ProductDetailsList)} instead")]
public IList<ProductDetails> ProductDetails
{
get => ProductDetailsList;
set { /* Obsolete property setter does nothing */ }
}
}

public class QueryPurchasesResult
{
public BillingResult Result { get; set; }
Expand Down Expand Up @@ -241,7 +255,11 @@ internal class InternalProductDetailsResponseListener : Java.Lang.Object, IProdu
public Action<BillingResult, QueryProductDetailsResult> ProductDetailsResponseHandler { get; set; }

public void OnProductDetailsResponse(BillingResult result, QueryProductDetailsResult queryResult)
=> ProductDetailsResponseHandler?.Invoke(result, queryResult);
{
queryResult ??= new();
queryResult.Result = result;
ProductDetailsResponseHandler?.Invoke(result, queryResult);
}
}

internal class InternalPurchasesResponseListener : Java.Lang.Object, IPurchasesResponseListener
Expand Down
Loading