Skip to content

Conversation

@moljac
Copy link
Contributor

@moljac moljac commented Sep 30, 2022

Does this change any of the generated binding API's?

No.

Describe your contribution

Context:

Seems like MAUI users are confused and not familiar with .NET MAUI (evolution of Xamarin.Forms)and .NET for Android (Xamarin.Android), so metadata is changed to express that bindings are for .NET Android (formerly Xamarin.Android).

nuspec for Xamarin.AndroidX.Browser.1.4.0.2.nuspec

    <description>.NET Android (formerly Xamarin.Android) bindings for AndroidX - artifact_versioned=androidx.browser:browser:1.4.0</description>
    <copyright>© Microsoft Corporation. All rights reserved.</copyright>
    <tags>.NET Android Xamarin AndroidX Xamarin.AndroidX Support Google browser artifact=androidx.browser:browser artifact_versioned=androidx.browser:browser:1.4.0</tags>

@moljac
Copy link
Contributor Author

moljac commented Oct 9, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpobst
Copy link
Contributor

jpobst commented Oct 10, 2022

Reminder that we have lots of templates for other bindings that will need this too.
https://github.com/xamarin/AndroidX/tree/main/templates

@jonpryor
Copy link
Contributor

These package metadata changes should be applied to all packages generated in this repo, including:

source/androidx.appcompat/typeforwarders/androidx.appcompat.appcompat-resources-typeforwarders.csproj:

<PackageTags>Xamarin AndroidX Xamarin.AndroidX Support Google appcompat-resources</PackageTags>

source/com.google.android.material/Xamarin.Google.Android.Material.Extensions/Xamarin.Google.Android.Material.Extensions.csproj:

<PackageTags>Xamarin AndroidX Xamarin.AndroidX Support Google material extensions</PackageTags>

templates/kotlin/Project.cshtml:

<PackageTags>Xamarin Kotlin Xamarin.Kotlin</PackageTags>

@moljac
Copy link
Contributor Author

moljac commented Oct 12, 2022

working on (need to check)

source/androidx.appcompat/typeforwarders/androidx.appcompat.appcompat-resources-typeforwarders.csproj:

<PackageTags>Xamarin AndroidX Xamarin.AndroidX Support Google appcompat-resources</PackageTags>

source/com.google.android.material/Xamarin.Google.Android.Material.Extensions/Xamarin.Google.Android.Material.Extensions.csproj:

<PackageTags>Xamarin AndroidX Xamarin.AndroidX Support Google material extensions</PackageTags>

templates/kotlin/Project.cshtml:

@moljac moljac marked this pull request as draft October 12, 2022 10:18
@moljac moljac marked this pull request as ready for review October 12, 2022 15:40
@moljac moljac merged commit c2c90e9 into main Oct 13, 2022
@moljac moljac deleted the mu-package-metadata-updates branch October 13, 2022 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants