Weekly stable updates 20230811 #773

moljac · 2023-08-11T07:31:25Z

Does this change any of the generated binding API's?

yes. New bindings +

Describe your contribution

Updated packages + new dependencies:

androidx.browser:browser - 1.5.0 -> 1.6.0
androidx.compose.animation:animation - 1.4.3 -> 1.5.0
androidx.compose.animation:animation-android - -> 1.5.0
androidx.compose.animation:animation-core - 1.4.3 -> 1.5.0
androidx.compose.animation:animation-core-android - -> 1.5.0
androidx.compose.animation:animation-graphics - 1.4.3 -> 1.5.0
androidx.compose.animation:animation-graphics-android - -> 1.5.0
androidx.compose.foundation:foundation - 1.4.3 -> 1.5.0
androidx.compose.foundation:foundation-android - -> 1.5.0
androidx.compose.foundation:foundation-layout - 1.4.3 -> 1.5.0
androidx.compose.foundation:foundation-layout-android - -> 1.5.0
androidx.compose.material:material - 1.4.3 -> 1.5.0
androidx.compose.material:material-android - -> 1.5.0
androidx.compose.material:material-icons-core - 1.4.3 -> 1.5.0
androidx.compose.material:material-icons-core-android - -> 1.5.0
androidx.compose.material:material-icons-extended - 1.4.3 -> 1.5.0
androidx.compose.material:material-icons-extended-android - -> 1.5.0
androidx.compose.material:material-ripple - 1.4.3 -> 1.5.0
androidx.compose.material:material-ripple-android - -> 1.5.0
androidx.compose.runtime:runtime - 1.4.3 -> 1.5.0
androidx.compose.runtime:runtime-android - -> 1.5.0
androidx.compose.runtime:runtime-livedata - 1.4.3 -> 1.5.0
androidx.compose.runtime:runtime-rxjava2 - 1.4.3 -> 1.5.0
androidx.compose.runtime:runtime-rxjava3 - 1.4.3 -> 1.5.0
androidx.compose.runtime:runtime-saveable - 1.4.3 -> 1.5.0
androidx.compose.runtime:runtime-saveable-android - -> 1.5.0
androidx.compose.ui:ui - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-android - -> 1.5.0
androidx.compose.ui:ui-geometry - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-geometry-android - -> 1.5.0
androidx.compose.ui:ui-graphics - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-graphics-android - -> 1.5.0
androidx.compose.ui:ui-text - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-text-android - -> 1.5.0
androidx.compose.ui:ui-tooling - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-tooling-android - -> 1.5.0
androidx.compose.ui:ui-tooling-data - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-tooling-data-android - -> 1.5.0
androidx.compose.ui:ui-tooling-preview - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-tooling-preview-android - -> 1.5.0
androidx.compose.ui:ui-unit - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-unit-android - -> 1.5.0
androidx.compose.ui:ui-util - 1.4.3 -> 1.5.0
androidx.compose.ui:ui-util-android - -> 1.5.0
androidx.compose.ui:ui-viewbinding - 1.4.3 -> 1.5.0
androidx.emoji2:emoji2 - 1.3.0 -> 1.4.0
androidx.emoji2:emoji2-viewshelper - 1.3.0 -> 1.4.0
androidx.navigation:navigation-common - 2.6.0 -> 2.7.0
androidx.navigation:navigation-common-ktx - 2.6.0 -> 2.7.0
androidx.navigation:navigation-compose - 2.6.0 -> 2.7.0
androidx.navigation:navigation-fragment - 2.6.0 -> 2.7.0
androidx.navigation:navigation-fragment-ktx - 2.6.0 -> 2.7.0
androidx.navigation:navigation-runtime - 2.6.0 -> 2.7.0
androidx.navigation:navigation-runtime-ktx - 2.6.0 -> 2.7.0
androidx.navigation:navigation-ui - 2.6.0 -> 2.7.0
androidx.navigation:navigation-ui-ktx - 2.6.0 -> 2.7.0
androidx.preference:preference-ktx - 1.2.0 -> 1.2.1
androidx.wear:wear - 1.2.0 -> 1.3.0
androidx.wear.compose:compose-foundation - 1.1.2 -> 1.2.0
androidx.wear.compose:compose-material - 1.1.2 -> 1.2.0
androidx.wear.compose:compose-material-core - -> 1.2.0
androidx.wear.compose:compose-navigation - 1.1.2 -> 1.2.0
androidx.wear.protolayout:protolayout - -> 1.0.0
androidx.wear.protolayout:protolayout-expression - -> 1.0.0
androidx.wear.protolayout:protolayout-expression-pipeline - -> 1.0.0
androidx.wear.protolayout:protolayout-proto - -> 1.0.0

jpobst

Previously, we had decided that we would not provide C# bindings for Compose, only the Java packages needed at runtime. This was so that people wouldn't expect to be able to use them to create Compose layouts (which is only supported in Kotlin).

This PR appears to add C# bindings for several of the new Compose packages, should we strip out the bindings and only do Java packages like the others?

config.json

jpobst · 2023-08-22T14:16:28Z

config.json

+        "version": "1.0.0",
+        "nugetVersion": "1.0.0",
+        "nugetId": "Xamarin.AndroidX.ProtoLayout.Expression",
+        "excludedRuntimeDependencies": "org.jetbrains.kotlin.kotlin-stdlib",


Why exclude kotlin-stdlib? We bind that package.

I think copypasta.

No it was not copypasta without that line binderator crashes:

Unhandled exception. System.ArgumentNullException: Value cannot be null. (Parameter 'input') at System.Text.RegularExpressions.ThrowHelper.ThrowArgumentNullException(ExceptionArgument arg) at MavenNet.MavenVersionRange.Satisfies(String version) at MavenNet.Models.Dependency.Satisfies(String version) at AndroidBinderator.Engine.<>c__DisplayClass7_0.<BuildProjectModels>b__0(MavenArtifactConfig ma) in C:\a\_work\1\s\util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\Engine.cs:line 333 at System.Linq.Enumerable.TryGetFirst[TSource](IEnumerable`1 source, Func`2 predicate, Boolean& found) at AndroidBinderator.Engine.BuildProjectModels(BindingConfig config, Dictionary`2 mavenProjects) in C:\a\_work\1\s\util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\Engine.cs:line 330 at AndroidBinderator.Engine.ProcessConfig(BindingConfig config) in C:\a\_work\1\s\util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\Engine.cs:line 75 at AndroidBinderator.Engine.BinderateAsync(BindingConfig config) in C:\a\_work\1\s\util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator\Engine.cs:line 46 at Xamarin.AndroidBinderator.Tool.Program.Main(String[] args) in C:\a\_work\1\s\util\Xamarin.AndroidBinderator\Xamarin.AndroidBinderator.Tool\Program.cs:line 67 at Xamarin.AndroidBinderator.Tool.Program.<Main>(String[] args)

pom.xml

<?xml version="1.0" encoding="UTF-8"?> <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">      <modelVersion>4.0.0</modelVersion> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-expression</artifactId> <version>1.0.0</version> <packaging>aar</packaging> <name>ProtoLayout Expression</name> <description>Create dynamic expressions (for late evaluation by a remote evaluator).</description> <url>https://developer.android.com/jetpack/androidx/releases/wear-protolayout#1.0.0</url> <inceptionYear>2022</inceptionYear> <licenses> <license> <name>The Apache Software License, Version 2.0</name> <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url> <distribution>repo</distribution> </license> </licenses> <developers> <developer> <name>The Android Open Source Project</name> </developer> </developers> <scm> <connection>scm:git:https://android.googlesource.com/platform/frameworks/support</connection> <url>https://cs.android.com/androidx/platform/frameworks/support</url> </scm> <dependencyManagement> <dependencies> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout</artifactId> <version>1.0.0</version> </dependency> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-expression-pipeline</artifactId> <version>1.0.0</version> </dependency> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-material</artifactId> <version>1.0.0</version> </dependency> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-proto</artifactId> <version>1.0.0</version> </dependency> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-renderer</artifactId> <version>1.0.0</version> </dependency> </dependencies> </dependencyManagement> <dependencies> <dependency> <groupId>androidx.annotation</groupId> <artifactId>annotation</artifactId> <version>1.2.0</version> <scope>compile</scope> </dependency> <dependency> <groupId>androidx.annotation</groupId> <artifactId>annotation-experimental</artifactId> <version>1.3.0</version> <scope>runtime</scope> <type>aar</type> </dependency> <dependency> <groupId>androidx.collection</groupId> <artifactId>collection</artifactId> <version>1.2.0</version> <scope>runtime</scope> </dependency> <dependency> <groupId>androidx.wear.protolayout</groupId> <artifactId>protolayout-proto</artifactId> <version>[1.0.0]</version> <scope>runtime</scope> </dependency> <dependency> <groupId>org.jetbrains.kotlin</groupId> <artifactId>kotlin-stdlib</artifactId> <scope>runtime</scope> </dependency> </dependencies> </project>

And there is also Wear. missing!!!!!

Try adding:

"extraDependencies": "org.jetbrains.kotlin.kotlin-stdlib"

Which should add the dependency to the package using the version we specify in this file.

extraDependencies crashes too.

config.json

jpobst · 2023-08-22T14:29:31Z

published-namespaces.txt

+AndroidX.Compose.Material.Icons.Sharp
+AndroidX.Compose.Material.Icons.TwoTone
+AndroidX.Compose.Material.Internal
+AndroidX.Compose.Material.Pullrefresh


The following compound words need capitalization fixes:
PullRefresh
HapticFeedback
CoreShims
DataSource
ViewInterop
MaterialCore
ProtoLayout

good spot. I opened file, but did not finish it.

moljac · 2023-08-22T16:01:00Z

Previously, we had decided that we would not provide C# bindings for Compose, only the Java packages needed at runtime. This was so that people wouldn't expect to be able to use them to create Compose layouts (which is only supported in Kotlin).

I remember. I skipped those because they did not require metadata and I did not check generated MCWs.

This PR appears to add C# bindings for several of the new Compose packages, should we strip out the bindings and only do Java packages like the others?

For now I will remove MCWs, but in the future I'd like to surface those APIs, but to write docs that it is not usable from C#, hoping we come up with something in the future.

jpobst · 2023-08-24T14:04:11Z

config.json

+        "artifactId": "ui-android",
+        "version": "1.5.0",
+        "nugetVersion": "1.5.0",
+        "nugetId": "Xamarin.AndroidX.Compose.UIAndroid",


UI.Android

jpobst · 2023-08-24T14:07:08Z

config.json

+        "version": "1.0.0",
+        "nugetVersion": "1.0.0",
+        "nugetId": "Xamarin.AndroidX.ProtoLayout.Expression",
+        "excludedRuntimeDependencies": "org.jetbrains.kotlin.kotlin-stdlib",


Try adding:

"extraDependencies": "org.jetbrains.kotlin.kotlin-stdlib"

Which should add the dependency to the package using the version we specify in this file.

jpobst · 2023-08-24T14:08:56Z

source/androidx.compose.foundation/foundation-layout-android/Additions/Additions.cs

+
+	// Metadata.xml XPath class reference: path="/api/package[@name='androidx.compose.foundation.layout']/class[@name='PaddingValues.Absolute']"
+	// [global::Android.Runtime.Register ("androidx/compose/foundation/layout/PaddingValues$Absolute", DoNotGenerateAcw=true)]
+	public sealed partial class PaddingValuesAbsolute //: global::Java.Lang.Object, global::AndroidX.Compose.Foundation.Layout.IPaddingValues 


Need to remove or comment this out, as there are no C# bindings in this package.

jpobst · 2023-08-24T14:32:05Z

config.json

+        "artifactId": "animation-graphics-android",
+        "version": "1.5.0",
+        "nugetVersion": "1.5.0",
+        "nugetId": "Xamarin.AndroidX.Compose.Animation.Graphics.Android",


I think this one is missing:

<remove-node path="/api/package" />

There were several Metadata files missing, so these were not included in projects and thus no transformation happened and MCWs were created.

I have added metadata and now it should be OK.

Accidentally hit Approve instead of Comment

published-namespaces.txt

…tasource

Weekly stable updates

1e1fa65

moljac marked this pull request as draft August 11, 2023 07:31

moljac added 21 commits August 13, 2023 11:39

binderator green

06c0f62

binderator green - additonal fixes

2afcea1

metadata initial commit

01d5796

protolayout-proto metadata fixes

36178e1

metadate fixes

b02943f

Update Metadata.xml

417b452

androidx.compose.ui metadata initial comit - files

6cc86b4

further metadata fixes

826d9c2

ui-text-andrioid fixes

37b0e84

Update Metadata.xml

80864d3

more fixes

e263e5d

foundation-layout-android metadata

2213774

Update Metadata.xml

ce58420

foundation-android metadata

ad9250d

Update Additions.cs

76321fa

binderator green

64e5c7c

automatic files

dab9f2f

Update published-namespaces.txt

4dcbff7

spell checking

227bdd1

Merge branch 'main' into create-pull-request/patch-1691733771

d80fe79

Update artifact-list-with-versions.md

4726d8d

moljac marked this pull request as ready for review August 22, 2023 09:06

moljac requested a review from jpobst August 22, 2023 09:06

jpobst reviewed Aug 22, 2023

View reviewed changes

moljac added 3 commits August 22, 2023 19:18

fixes according to review

c15fcc7

Update Directory.Build.props

913dba3

reverting problematic updates

453c24f

moljac added 5 commits August 23, 2023 13:32

removed MCWs

c2eb154

missing metadata

10ce9f9

Update published-namespaces.txt

2d0f0ed

more missing metadata

9a690a0

Update published-namespaces.txt

b1c445c

moljac requested a review from jpobst August 24, 2023 10:57

jpobst previously approved these changes Aug 24, 2023

View reviewed changes

This comment was marked as resolved.

Sign in to view

jpobst self-requested a review August 24, 2023 14:40

moljac added 6 commits August 24, 2023 17:10

missing metadata

45b6e6c

commented out

5826706

namespace fix

c383643

automatically generated files

ec9da89

Update published-namespaces.txt

d2d1f17

Merge branch 'main' into create-pull-request/patch-1691733771

cb671a9

jpobst mentioned this pull request Aug 28, 2023

[binderator] Allow extraDependencies to specify an excludedDependency. #780

Merged

moljac added 4 commits August 31, 2023 09:26

Merge branch 'main' into create-pull-request/patch-1691733771

40dbf33

Merge branch 'main' into create-pull-request/patch-1691733771

8ae91f5

binderator fix

17244e2

binderator bumped

7a06b42

jpobst reviewed Aug 31, 2023

View reviewed changes

published-namespaces.txt Outdated Show resolved Hide resolved

moljac added 3 commits September 1, 2023 14:34

new metadata according to review to rename namespace DataSource to Da…

b512120

…tasource

namespace fixes

79ac534

cleanup

b92a6e0

moljac requested a review from jpobst September 7, 2023 16:45

Remove unused metadata.

85c3009

jpobst approved these changes Sep 7, 2023

View reviewed changes

moljac merged commit 47baae8 into main Sep 10, 2023

moljac deleted the create-pull-request/patch-1691733771 branch September 10, 2023 17:37

Weekly stable updates 20230811 #773

Weekly stable updates 20230811 #773

Uh oh!

Conversation

moljac commented Aug 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Does this change any of the generated binding API's?

Describe your contribution

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

moljac commented Aug 22, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

moljac commented Aug 11, 2023 •

edited

Loading