Fix Windows to look in Assembly Directory for 32bit dll. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 96eb5e3 introduced the use of `DefaultDllImportSearchPathsAttribute` to add extra security when loading native libraries. This works fine when the executable that is running is in the same directory as the `LibZipSharp.dll` and the `libzip.dll`. However when the executable has a different `WorkingDirectory` as the `LibZipSharp.dll` this then causes the following error. System.DllNotFoundException: Unable to load DLL 'libzip' This is because with the new attribute only Safe paths are searched. So when we run this under MSBuild.exe for example, the `Working` directory will definately NOT contain the 32bit `libzip.dll`. The fix to to always set the location of the `libzip.dll` via `SetDllDirectory` for both 32bit and 64bit processes. Also bump to 1.0.18
grendello
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 96eb5e3 introduced the use of
DefaultDllImportSearchPathsAttributeto add extra security when loading native libraries. This
works fine when the executable that is running is in the
same directory as the
LibZipSharp.dlland thelibzip.dll.However when the executable has a different
WorkingDirectoryas the
LibZipSharp.dllthis then causes the followingerror.
This is because with the new attribute only Safe paths are searched.
So when we run this under MSBuild.exe for example, the
Workingdirectory will definately NOT contain the 32bit
libzip.dll.The fix to to always set the location of the
libzip.dllviaSetDllDirectoryfor both 32bit and 64bit processes.Also bump to 1.0.18