[build] set $(DisableTransitiveFrameworkReferenceDownloads)
#216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we consume nightly .NET 8 builds, they sometimes depend on nightly
.NET 7 builds.
One error you can run into is:
error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 7.0.11)
error NU1102: Unable to find package Microsoft.WindowsDesktop.App.Ref with version (= 7.0.11)
For projects that are not even ASP.NET or Windows desktop apps! To even
be able to access these feeds, they would be something like:
<add key="darc-pub-dotnet-aspnetcore-[SHA]" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-aspnetcore-[SHA]/nuget/v3/index.json" />
<add key="darc-pub-dotnet-windowsdesktop-[SHA]" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-windowsdesktop-[SHA]/nuget/v3/index.json" />
We don't currently track these packages, because we don't actually use
them.
The .NET SDK team has provided a setting to workaround this,
`$(DisableTransitiveFrameworkReferenceDownloads)`, we have been using in
xamarin/xamarin-android for some time:
https://github.com/xamarin/xamarin-android/blob/6768c731d327c8148c45304c895ca8987a9cc2f1/Directory.Build.props#L26-L27
Let's do the same here to avoid this problem as seen in 2b8ac12.
pjcollins
approved these changes
Aug 23, 2023
jonathanpeppers
deleted the
DisableTransitiveFrameworkReferenceDownloads
branch
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Sep 11, 2023
Changes: dotnet/android-tools@3cee10b...9c50a2d * dotnet/android-tools@9c50a2d: [build] set `$(DisableTransitiveFrameworkReferenceDownloads)`=true (dotnet/android-tools#216) * dotnet/android-tools@52f0866: [Xamarin.Android.Tools.AndroidSdk] Check all <intent-filter/>s (dotnet/android-tools#214) * dotnet/android-tools@57be026: [Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-34 (dotnet/android-tools#211) * dotnet/android-tools@0a9ea47: [Xamarin.Android.Tools.AndroidSdk] Add API-34 to KnownVersions (dotnet/android-tools#212) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonpryor
pushed a commit
to dotnet/android
that referenced
this pull request
Sep 20, 2023
Changes: dotnet/android-tools@52f0866...8a971d9 * dotnet/android-tools@8a971d9: Merge pull request dotnet/android-tools#217 from xamarin/dev/tondat/main-openjdkms * dotnet/android-tools@42bbef8: Update OpenJDK location for OpenJDK17 on windows * dotnet/android-tools@9c50a2d: [build] set `$(DisableTransitiveFrameworkReferenceDownloads)`=true (dotnet/android-tools#216) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
jonathanpeppers
added a commit
that referenced
this pull request
Dec 13, 2023
) As we consume nightly .NET 8 builds, they sometimes depend on nightly .NET 7 builds. One error you can run into is: error NU1102: Unable to find package Microsoft.AspNetCore.App.Ref with version (= 7.0.11) error NU1102: Unable to find package Microsoft.WindowsDesktop.App.Ref with version (= 7.0.11) For projects that are not even ASP.NET or Windows desktop apps! To even be able to access these feeds, they would need to be an entry within `NuGet.config` similar to <packageSources> <clear/> <add key="darc-pub-dotnet-aspnetcore-[SHA]" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-aspnetcore-[SHA]/nuget/v3/index.json" /> <add key="darc-pub-dotnet-windowsdesktop-[SHA]" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-windowsdesktop-[SHA]/nuget/v3/index.json" /> </packageSources> We don't currently track these packages, because we don't actually use them. The .NET SDK team has provided a setting to workaround this, [`$(DisableTransitiveFrameworkReferenceDownloads)`][0], we have been [using in xamarin/xamarin-android for some time][1]. Let's do the same here to avoid this problem as seen in 2b8ac12. [0]: https://learn.microsoft.com/en-us/dotnet/core/project-sdk/msbuild-props#disabletransitiveframeworkreferencedownloads [1]: https://github.com/xamarin/xamarin-android/blob/6768c731d327c8148c45304c895ca8987a9cc2f1/Directory.Build.props#L26-L27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we consume nightly .NET 8 builds, they sometimes depend on nightly .NET 7 builds.
One error you can run into is:
For projects that are not even ASP.NET or Windows desktop apps! To even be able to access these feeds, they would be something like:
We don't currently track these packages, because we don't actually use them.
The .NET SDK team has provided a setting to workaround this,
$(DisableTransitiveFrameworkReferenceDownloads), we have been using in xamarin/xamarin-android for some time:https://github.com/xamarin/xamarin-android/blob/6768c731d327c8148c45304c895ca8987a9cc2f1/Directory.Build.props#L26-L27
Let's do the same here to avoid this problem as seen in 2b8ac12.