[build] update $(MSBuildPackageReferenceVersion) to 17.6.3 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #221, we updated
$(MSBuildPackageReferenceVersion)to17.8.3. This caused some issues for XA, potentially because17.8.3changes its TF fromnet7.0tonet8.0.Using the new conditional to overcome this is cumbersome, as we use
Microsoft.Android.Build.BaseTasks.csprojfrom the XAT repo, and it does not inherit the value from XA'sDirectory.Build.props. We would need to introduce anexternal/xamarin-android-tools.override.props, etc.For now, let's revert to
17.6.3. Once XA has been updated to .NET 9 we could probably update to17.8.3if desired.Green XA test bump: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8749478&view=results