[Xamarin.Android.Tools.AndroidSdk] Remove net461 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@DmitriyKirakosyan ran into a build failure when attempting to bump xamarin/android-sdk-installer to use commit bfb66f3: external\androidtools\external\xamarin-android-tools\src\Xamarin.Android.Tools.AndroidSdk\Xamarin.Android.Tools.AndroidSdk.csproj(0,0): Error MSB4057: The target "BuiltProjectOutputGroupDependencies" does not exist in the project. [Further investigation][0] showed that the MSB4057 occurs because `Xamarin.Android.Tools.AndroidSdk.csproj` uses the `$(TargetFrameworks)` property (plural), and to avoid the MSB4057 the `$(TargetFramework)` property (singular) should instead be used. As `Xamarin.Android.Tools.AndroidSdk.csproj` also targets .NET Standard 2.0, and [.NET Standard 2.0 supports .NET 4.6][1], we can fix the MSB4057 by dropping the build of `net461`. [0]: https://stackoverflow.com/a/43481827 [1]: https://docs.microsoft.com/en-us/dotnet/standard/net-standard
dellis1972
approved these changes
Feb 26, 2020
|
@monojenkins backport to d16-6 |
jonpryor
pushed a commit
that referenced
this pull request
Feb 25, 2021
Changes: dotnet/android-libzipsharp@1.0.22...1.0.23 * dotnet/android-libzipsharp@521b54e Include Windows pdb in Nuget (#82) * dotnet/android-libzipsharp@9853933: [ci] Update packageSources in NuGet.config (#80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DmitriyKirakosyan ran into a build failure when attempting to bump
xamarin/android-sdk-installer to use commit bfb66f3:
Further investigation showed that the MSB4057 occurs because
Xamarin.Android.Tools.AndroidSdk.csprojuses the$(TargetFrameworks)property (plural), and to avoid the MSB4057 the
$(TargetFramework)property (singular) should instead be used.
As
Xamarin.Android.Tools.AndroidSdk.csprojalso targets.NET Standard 2.0, and .NET Standard 2.0 supports .NET 4.6,
we can fix the MSB4057 by dropping the build of
net461.