Skip to content

Commit

Permalink
Bump cmake to version 3.22.1 (#6954)
Browse files Browse the repository at this point in the history
Updating cmake to version newer than 3.19 will make the following warning during our native code build
disappear:

    CMake Warning at ~/android-toolchain/ndk/build/cmake/android-legacy.toolchain.cmake:415 (message): (TaskId:583)
      An old version of CMake is being used that cannot automatically detect (TaskId:583)
      compiler attributes.  Compiler identification is being bypassed.  Some (TaskId:583)
      values may be wrong or missing.  Update to CMake 3.19 or newer to use (TaskId:583)
      CMake's built-in compiler identification. (TaskId:583)
    Call Stack (most recent call first): (TaskId:583)
      ~/android-toolchain/ndk/build/cmake/android.toolchain.cmake:54 (include) (TaskId:583)
      obj/Debug/armeabi-v7a-Debug/CMakeFiles/3.18.1-g262b901/CMakeSystem.cmake:6 (include) (TaskId:583)
      CMakeLists.txt:14 (project) (TaskId:583)
  • Loading branch information
grendello authored May 5, 2022
1 parent d8f8486 commit 1fa74d1
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Configuration.props
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@
<AndroidSdkDirectory Condition=" '$(AndroidSdkDirectory)' == '' ">$(AndroidToolchainDirectory)\sdk</AndroidSdkDirectory>
<AndroidNdkDirectory Condition=" '$(AndroidNdkDirectory)' == '' And Exists($(ANDROID_NDK_LATEST_HOME)) ">$(ANDROID_NDK_LATEST_HOME)</AndroidNdkDirectory>
<AndroidNdkDirectory Condition=" '$(AndroidNdkDirectory)' == '' ">$(AndroidToolchainDirectory)\ndk</AndroidNdkDirectory>
<AndroidCmakeVersion Condition=" '$(AndroidCmakeVersion)' == '' ">3.18.1</AndroidCmakeVersion>
<AndroidCmakeUrlPrefix Condition=" '$(HostOS)' == 'Windows' And '$(AndroidCmakeUrlPrefix)' == '' ">7c386a739f915f5bd60051f2572c24782388e807.</AndroidCmakeUrlPrefix>
<AndroidCmakeUrlPrefix Condition=" '$(HostOS)' == 'Darwin' And '$(AndroidCmakeUrlPrefix)' == '' ">ba34c321f92f6e6fd696c8354c262c122f56abf8.</AndroidCmakeUrlPrefix>
<AndroidCmakeVersion Condition=" '$(AndroidCmakeVersion)' == '' ">3.22.1</AndroidCmakeVersion>
<AndroidCmakeUrlPrefix Condition=" '$(HostOS)' == 'Windows' And '$(AndroidCmakeUrlPrefix)' == '' "></AndroidCmakeUrlPrefix>
<AndroidCmakeUrlPrefix Condition=" '$(HostOS)' == 'Darwin' And '$(AndroidCmakeUrlPrefix)' == '' "></AndroidCmakeUrlPrefix>
<AndroidCmakeUrlPrefix Condition=" '$(HostOS)' == 'Linux' And '$(AndroidCmakeUrlPrefix)' == '' "></AndroidCmakeUrlPrefix>
<AndroidCmakeVersionPath Condition=" '$(AndroidCmakeVersionPath)' == '' ">$(AndroidCmakeVersion)</AndroidCmakeVersionPath>
<AndroidSdkCmakeDirectory>$(AndroidSdkDirectory)\cmake\$(AndroidCmakeVersionPath)</AndroidSdkCmakeDirectory>
Expand Down

0 comments on commit 1fa74d1

Please sign in to comment.