[WIP] Remove API Level 10 from the builds. #1032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsushieno
force-pushed
the
remove-api-level-10
branch
from
2c94295 to
131da9d
Compare
atsushieno
force-pushed
the
remove-api-level-10
branch
from
131da9d to
5c5ed05
Compare
Contributor
|
This also needs to change e.g. |
atsushieno
force-pushed
the
remove-api-level-10
branch
from
5c5ed05 to
9e82022
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Dec 15, 2017
Context: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#API-10_is_Obsolete Context: dotnet#1105 Context: dotnet#1032 In Xamarin.Android 7.4, we announced that API-10 was obsolete and would be removed in a future release. PR dotnet#1032 attempted to do so, but does not yet work, so until now we have continued shipping API-10 assemblies, even though Xamarin.Android 7.4 hit stable on 2017-Aug-11. Meanwhile, PR dotnet#1105 includes an NDK bump, which in turn means that the lowest API level we can compile for will be *API-14*. Attempt to split the difference, assuming PR dotnet#1105 lands before PR dotnet#1032: Keep the supporting files for API-10, but don't build them, and explicitly remove `v2.3` from the `.vsix` file.
atsushieno
force-pushed
the
remove-api-level-10
branch
2 times, most recently
from
2793e75 to
b23f085
Compare
jonpryor
added a commit
that referenced
this pull request
Dec 16, 2017
Context: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#API-10_is_Obsolete Context: #1105 Context: #1032 In Xamarin.Android 7.4, we announced that API-10 was obsolete and would be removed in a future release. PR #1032 attempted to do so, but does not yet work, so until now we have continued shipping API-10 assemblies, even though Xamarin.Android 7.4 hit stable on 2017-Aug-11. Meanwhile, PR #1105 changes NDK use semantics such that *API-14* is now the lowest supported API level for NDK use. There is thus no point in shipping API-10 bindings. Attempt to split the difference, assuming PR #1105 lands before PR #1032: Keep the supporting files for API-10, but don't build them, and explicitly remove `v2.3` from the `.vsix` file.
Contributor
Author
|
build |
atsushieno
force-pushed
the
remove-api-level-10
branch
from
b23f085 to
5ca0830
Compare
atsushieno
force-pushed
the
remove-api-level-10
branch
from
5ca0830 to
190e3bd
Compare
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 29, 2018
Context: dotnet#1032 We previously obsoleted support for API levels earlier than API-19; see commit 66e1b65. Next up: stop *building* `Mono.Android.dll` and related assemblies for API levels earlier than API-19, and stop *shipping* `Mono.Android.dll` assemblies for `$(TargetFrameworkVersion)` values before `v4.4` (19). PR dotnet#1032 previously tried to do this, and failed, because it attempted to do "too much," removing code from `Mono.Android.dll` *as well as* removing support for *building* the obsolete API levels. Simplify things by *just* altering the build system and *not* the source code within `Mono.Android.dll`.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Nov 30, 2018
Context: dotnet#1032 We previously obsoleted support for API levels earlier than API-19; see commit 66e1b65. Next up: stop *building* `Mono.Android.dll` and related assemblies for API levels earlier than API-19, and stop *shipping* `Mono.Android.dll` assemblies for `$(TargetFrameworkVersion)` values before `v4.4` (19). PR dotnet#1032 previously tried to do this, and failed, because it attempted to do "too much," removing code from `Mono.Android.dll` *as well as* removing support for *building* the obsolete API levels. Simplify things by *just* altering the build system and *not* the source code within `Mono.Android.dll`.
jonpryor
added a commit
that referenced
this pull request
Nov 30, 2018
Context: #1032 We previously obsoleted support for API levels earlier than API-19; see commit 66e1b65. Next up: stop *building* `Mono.Android.dll` and related assemblies for API levels earlier than API-19, and stop *shipping* `Mono.Android.dll` assemblies for `$(TargetFrameworkVersion)` values before `v4.4` (19). PR #1032 previously tried to do this, and failed, because it attempted to do "too much," removing code from `Mono.Android.dll` *as well as* removing support for *building* the obsolete API levels. Simplify things by *just* altering the build system and *not* the source code within `Mono.Android.dll`.
Contributor
Author
|
The minimum supported API Level is 19 now, right? That's awesome and there is no point of keeping this PR alive. Let me just close it. |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 15, 2022
Fixes: dotnet/java-interop#1031 Changes: dotnet/java-interop@2c8b0a8...fcc33ce * dotnet/java-interop@fcc33ce2: [java-source-utils] Add `$schema` to `CGManifest.json` (dotnet#1035) * dotnet/java-interop@58de60f2: [generator] Handle Java class with base class set to itself. (dotnet#1032)
jonpryor
added a commit
that referenced
this pull request
Sep 16, 2022
Fixes: dotnet/java-interop#1031 Changes: dotnet/java-interop@2c8b0a8...fcc33ce * dotnet/java-interop@fcc33ce2: [java-source-utils] Add `$schema` to `CGManifest.json` (#1035) * dotnet/java-interop@58de60f2: [generator] Handle Java class with base class set to itself. (#1032)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.