-
Notifications
You must be signed in to change notification settings - Fork 564
Enable more tests to run on all 3 runtimes, part 5 #10592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+602
−157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7943a7 to
e76d59d
Compare
…ithValidLogicalName works
e76d59d to
c59293f
Compare
jonathanpeppers
approved these changes
Nov 24, 2025
Member
jonathanpeppers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This pull request expands test coverage across the Xamarin.Android build task tests to support and validate multiple Android runtimes (such as MonoVM, CoreCLR, and NativeAOT). The changes systematically update test cases to parameterize the runtime, ensure correct configuration for each runtime, and handle unsupported scenarios gracefully. Helper methods and test data sources are also refactored to facilitate multi-runtime testing.
Multi-runtime test support and parameterization:
AidlTest.cs,AndroidDependenciesTests.cs, andAndroidGradleProjectTests.csto accept anAndroidRuntimeparameter using the[Values]attribute, enabling tests to run across all supported runtimes. Tests now callproj.SetRuntime(runtime)and set theIsReleaseproperty based on the runtime. Unsupported configurations are skipped usingIgnoreUnsupportedConfiguration.Test data refactoring for runtime coverage:
Get_AGPMetadataTestSources,Get_GetDependencyNdkRequiredConditionsData) to generate test data for each runtime, ensuring comprehensive coverage and reducing code duplication.Test output and assertion improvements:
Graceful handling of unsupported scenarios:
Consistency and maintainability enhancements: