-
Notifications
You must be signed in to change notification settings - Fork 564
[build] setup public pipeline on dnceng-public
#10636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
##[warning]Free disk space on D:\ is lower than 5%; Currently used: 98.03%
Member
Author
|
Example green dnceng pipeline (all tests): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors and modernizes the Azure Pipelines YAML configuration for .NET for Android, with a focus on improving maintainability, reusability, and clarity. The main changes involve introducing shared build step templates for macOS and Linux, simplifying the main public pipeline YAML, and cleaning up the Linux build pipeline to use these new templates.
Key changes include:
Pipeline Structure & Modularity:
build-macos-steps.yamlandbuild-linux-steps.yaml, encapsulating the core build logic for macOS and Linux respectively, and removing direct references to private repositories. This allows both public and private pipelines to reuse the same build steps.azure-pipelines-public.yaml) to use these shared templates for the macOS and Linux build stages, and to streamline job definitions.Linux Build Pipeline Cleanup:
build-linux.yamlto delegate all build logic to the newbuild-linux-steps.yamltemplate, removing duplicated inline steps and making the pipeline more maintainable.Build Artifact Management:
Pipeline Parameters and Conditions:
These changes make the build pipeline easier to maintain, encourage reuse, and reduce duplication.
Most important changes:
Pipeline Modularity and Refactoring
build-macos-steps.yamlandbuild-linux-steps.yamltemplates to encapsulate platform-specific build logic, making it reusable and independent of private repos.azure-pipelines-public.yamlto use these new templates, simplifying stage and job definitions for public builds.Linux Build Pipeline Improvements
build-linux.yamlto remove inline build steps and instead invoke the newbuild-linux-steps.yamltemplate, reducing duplication and centralizing logic.Artifact Handling Standardization
Pipeline Parameters and Test Skipping Logic
azure-pipelines-public.yamlto control test execution and agent selection, including auto-skipping tests for non-fork PRs.