[Xamarin.Android.Build.Tasks] Use full path to create designer output directory. #1542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… directory. Fixes dotnet#1541 We missed one area in the changes where we worked around the WorkingDirectory issues. We were not using the full path to create the directory where the java R.java files are output. As a result we ended up with the following error Error Access to the path 'obj\Debug\monoandroid81\android\src' is denied. at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.Directory.InternalCreateDirectory(String fullPath, String path, Object dirSecurityObj, Boolean checkHost) at System.IO.Directory.InternalCreateDirectoryHelper(String path, Boolean checkHost) at System.IO.Directory.CreateDirectory(String path) at Xamarin.Android.Tasks.Aapt.GenerateCommandLineCommands(String ManifestFile, String currentAbi, String currentResourceOutputFile) at Xamarin.Android.Tasks.Aapt.ProcessManifest(ITaskItem manifestFile) Once again this is due to the working directory changing in the thread that we are using. So the solution is to use the full path to create the folder. In theory because we use the `WorkingDirectory` on the process we should NOT need to pass the full path as the command line argument. While that might be a safer option we might well run into issues were we exceed the max path or max command line length on windows.
Contributor
Author
|
It has been confirmed by a customer that this PR fixes the issue reported. |
dellis1972
added
regression
vs-sync
dellis1972
removed
the
vs-sync
jonpryor
pushed a commit
that referenced
this pull request
Apr 11, 2018
… directory. (#1542) Fixes: #1541 We missed one area in the changes where we worked around the WorkingDirectory issues (45efffe): we were not using the full path to create the directory where the java `R.java` files are output. As a result we ended up with the following error: Error Access to the path 'obj\Debug\monoandroid81\android\src' is denied. at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath) at System.IO.Directory.InternalCreateDirectory(String fullPath, String path, Object dirSecurityObj, Boolean checkHost) at System.IO.Directory.InternalCreateDirectoryHelper(String path, Boolean checkHost) at System.IO.Directory.CreateDirectory(String path) at Xamarin.Android.Tasks.Aapt.GenerateCommandLineCommands(String ManifestFile, String currentAbi, String currentResourceOutputFile) at Xamarin.Android.Tasks.Aapt.ProcessManifest(ITaskItem manifestFile) Once again this is due to the working directory changing in the thread that we are using. So the solution is to use the full path to create the folder. In theory because we use the `WorkingDirectory` on the process we should NOT need to pass the full path as the command line argument. While that might be a safer option we might well run into issues were we exceed the max path or max command line length on Windows.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1541
We missed one area in the changes where we worked around
the WorkingDirectory issues. We were not using the full path
to create the directory where the java R.java files are output.
As a result we ended up with the following error
Once again this is due to the working directory changing in the
thread that we are using.
So the solution is to use the full path to create the folder.
In theory because we use the
WorkingDirectoryon the processwe should NOT need to pass the full path as the command line
argument. While that might be a safer option we might well run into
issues were we exceed the max path or max command line length on
windows.