[tests] fix CheckTargetFrameworkVersion tests #1949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet#1916 These tests were never quite right, since they were just looking for instances of `TargetFrameworkVersion` in the build log. This would match for inputs and outputs, and wasn't actually testing anything because it appeared to always pass. In dotnet#1916 I improved them by looking for `Output Property: TargetFrameworkVersion=v2.3`, but they were not passing. Two issues to fix: - These tests should set `AndroidUseLatestPlatformSdk=False` - These tests shouldn't use `StringAssertEx.Contains` because it calls `Assert.Pass`, skipping any future assertions... When testing on Windows, these tests get skipped, so I had to fix things on Mac. The PR builder also skips them, so we did not see the issue until it was merged into master.
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2018
Context: #1916 These tests were never quite right, since they were just looking for instances of `TargetFrameworkVersion` in the build log. This would match for inputs and outputs, and wasn't actually testing anything because it appeared to always pass. In #1916 I improved them by looking for `Output Property: TargetFrameworkVersion=v2.3`, but they were not passing. Two issues to fix: - These tests should set `AndroidUseLatestPlatformSdk=False` - These tests shouldn't use `StringAssertEx.Contains` because it calls `Assert.Pass`, skipping any future assertions... When testing on Windows, these tests get skipped, so I had to fix things on Mac. The PR builder also skips them, so we did not see the issue until it was merged into master.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #1916
These tests were never quite right, since they were just looking for
instances of
TargetFrameworkVersionin the build log. This wouldmatch for inputs and outputs, and wasn't actually testing anything
because it appeared to always pass.
In #1916 I improved them by looking for
Output Property: TargetFrameworkVersion=v2.3, but they werenot passing.
Two issues to fix:
AndroidUseLatestPlatformSdk=FalseStringAssertEx.Containsbecause it callsAssert.Pass, skipping any future assertions...When testing on Windows, these tests get skipped, so I had to fix
things on Mac. The PR builder also skips them, so we did not see the
issue until it was merged into master.