Update emulator to the latest version, switch to API 28 #2119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
emulator-update
branch
2 times, most recently
from
2642123 to
5d311e7
Compare
dellis1972
approved these changes
Aug 30, 2018
This commit updates the Android emulator to the latest version
available (`4969155` a.k.a. v27.3.10), switches its system image to API 28,
makes sure that the emulator is started from the `emulator` subdir of the
Android SDK root (the binary in `tools` won't work anymore) and makes sure we
don't error out when we attempt to uninstall packages that don't exist in the
AVD.
In addition to those changes, two new properties were added to the
`CreateAndroidEmulator` task:
* `RamSizeMB` (defaults to `2048`)
Allows to set the emulator's RAM size
* `DataPartitionSizeMB` (defaults to `2048`)
Allows to set the emulator's data partition size. The data partition
cretaed by default has only around 800MB of space available which may not
be enough to install and run all our tests.
grendello
force-pushed
the
emulator-update
branch
from
5d311e7 to
6cb5685
Compare
But is it actually foolish?
jonathanpeppers
pushed a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Sep 11, 2018
…et#2119) Updates the Android emulator to the latest version available, currently `4969155` a.k.a. v27.3.10, and: * Switch its system image to API-28, and * Make sure that the emulator is started from the `emulator` subdir of the Android SDK root (the binary in `tools` won't work anymore), * Attempt to not error out when we uninstall packages that don't exist in the AVD. In addition to those changes, two new properties were added to the `<CreateAndroidEmulator/>` task: * `DataPartitionSizeMB` (defaults to `2048`): Sets the emulator's data partition size. The data partition created by default has only around 800MB of space available, which may not be enough to install and run all our tests. * `RamSizeMB` (defaults to `2048`): Sets the emulator's RAM size
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 11, 2018
…et#2119) Updates the Android emulator to the latest version available, currently `4969155` a.k.a. v27.3.10, and: * Switch its system image to API-28, and * Make sure that the emulator is started from the `emulator` subdir of the Android SDK root (the binary in `tools` won't work anymore), * Attempt to not error out when we uninstall packages that don't exist in the AVD. In addition to those changes, two new properties were added to the `<CreateAndroidEmulator/>` task: * `DataPartitionSizeMB` (defaults to `2048`): Sets the emulator's data partition size. The data partition created by default has only around 800MB of space available, which may not be enough to install and run all our tests. * `RamSizeMB` (defaults to `2048`): Sets the emulator's RAM size
jonpryor
added a commit
that referenced
this pull request
Sep 11, 2018
Context: #2157 Merge commit; cherry-picks the following commits from master: * d01e4ce (PR #2087): Revert "[mono-sdks] Use for android toolchain" * 7c51a91 (PR #2119): [tests] Update emulator to the latest version, switch to API 28 We're hoping that the emulator update will make unit test execution more reliable; see also PR #2157, which often has a crash when running some unit tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Android emulator to the latest version
available (
4969155a.k.a. v27.3.10), switches its system image to API 28,makes sure that the emulator is started from the
emulatorsubdir of theAndroid SDK root (the binary in
toolswon't work anymore) and makes sure wedon't error out when we attempt to uninstall packages that don't exist in the
AVD.