[Tests] Fix Layout so the test app actually runs #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when running the Mono.Android-Test app we get the following error Java.Lang.RuntimeException: Binary XML file line #1: You must supply a layout_width attribute. This is because the `ScrollView` now needs to have the `layout` properties for `width` and `height`. Filling those in we then get Scrollview can host only one direct child So we then need to add a `LinearLayout` to the `ScrollView` so that it removes that error as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when running the Mono.Android-Test app
we get the following error
This is because the
ScrollViewnow needs to havethe
layoutproperties forwidthandheight.Filling those in we then get
So we then need to add a
LinearLayoutto theScrollViewso that it removes that error as well.