[Xamarin.Android.Build.Tasks] Split up XA3001 errors and move them into .resx file #4176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to .resx file Context: [0342fe5][0] Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Split up the different uses of XA3001 by giving each error condition its own code. This makes it possible to gather telemetry for each condition separately, and it also makes it easier for users to search for the particular code they are seeing. Move XA3001 and the other new error codes to the `.resx` file so that they are localizable. Remove the `try-catch` from `CilStrip.RunTask()` because after [d4c8f07][1], the `AndroidTask` base class now provides that functionality. [0]: dotnet@0342fe5 [1]: dotnet@d4c8f07
brendanzagaeski
requested review from
dellis1972 and
jonathanpeppers
as code owners
dellis1972
reviewed
Jan 27, 2020
| } catch (Exception e) { | ||
| Log.LogCodedError ("XA3001", "{0}", e); | ||
| return false; | ||
| } |
Contributor
There was a problem hiding this comment.
Should we remove this? What happens if we get an error which we are not expecting? This would then bubble up to MSBuild and give a horrible MSxxxx error. Should we keep a generic error here which asked users to report the issue ?
Member
There was a problem hiding this comment.
Thanks to Pobst, it should go through here now: https://github.com/xamarin/xamarin-android/blob/1bee4ad176863bdfc0de258542a2c3685fc60f2d/src/Xamarin.Android.Build.Tasks/Tasks/AndroidTask.cs#L16-L21
I think using the default "let it throw" behavior is better now as long as this subclasses AndroidTask.
jonathanpeppers
approved these changes
Jan 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0342fe56
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/
Split up the different uses of XA3001 by giving each error condition its
own code. This makes it possible to gather telemetry for each condition
separately, and it also makes it easier for users to search for the
particular code they are seeing.
Move XA3001 and the other new error codes to the
.resxfile so thatthey are localizable.
Remove the
try-catchfromCilStrip.RunTask()because afterd4c8f077, the
AndroidTaskbase class now provides thatfunctionality.