[Xamarin.Android.Build.Tasks] ValidateJavaVersion l10n support #4340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: 0342fe5 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Move the message strings for XA0030, XA0031, XA0032, XA0033, & XA0034 into the `.resx` file so that they are localizable. Other changes: Use the literal name `$(TargetFrameworkVersion)` so that it doesn't need to be localized. Standardize the name "Android SDK Build-Tools" to match XA5205. Replace a usage of "it" in the message for XA0033 to reduce potential ambiguity for the l10n team.
brendanzagaeski
requested review from
dellis1972,
jonathanpeppers and
jonpryor
as code owners
dellis1972
approved these changes
Mar 2, 2020
jonpryor
pushed a commit
that referenced
this pull request
Mar 3, 2020
Context: 0342fe5 Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/ Move the message strings for XA0030, XA0031, XA0032, XA0033, & XA0034 into the `.resx` file so that they are localizable. Other changes: Use the literal name `$(TargetFrameworkVersion)` so that it doesn't need to be localized. Standardize the name "Android SDK Build-Tools" to match XA5205. Replace a usage of "it" in the message for XA0033 to reduce potential ambiguity for the l10n team.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: 0342fe5
Context: https://dev.azure.com/devdiv/DevDiv/_workitems/edit/1009374/
Move the message strings for XA0030, XA0031, XA0032, XA0033, & XA0034
into the
.resxfile so that they are localizable.Other changes:
Use the literal name
$(TargetFrameworkVersion)so that it doesn't needto be localized.
Standardize the name "Android SDK Build-Tools" to match XA5205.
Replace a usage of "it" in the message for XA0033 to reduce potential
ambiguity for the l10n team.