[.NET 5] use $(OutputType) Exe for application vs library #4604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
force-pushed
the
net5-outputtype-exe
branch
from
248e71f to
a90f00a
Compare
dellis1972
approved these changes
Apr 23, 2020
pjcollins
approved these changes
Apr 23, 2020
In .NET 5, Xamarin.iOS is already using `<OutputType>Exe<OutputType>` to distinguish an iOS application vs an iOS class library. Xamarin.Android, however, is checking the existence of `Properties/AndroidManifest.xml`. This brings up some issues: * When using a multi-targeted project in .NET, we should be using the same convention to distinguish library vs applications on both iOS and Android. * Xamarin.iOS apps have a `static void Main` method. `OutputType=Exe` makes sense, as it tells Roslyn to expect a `Main` method. To consolidate this, I propose: * Use `$(OutputType)` of `Exe` to set `$(AndroidApplication)` to `true`. No longer look for `AndroidManifest.xml` for this default. * Immediately set `$(OutputType)` to `Library`, since we *never* want a `Main` method on Android. To make this work, I had to move these defaults from `Xamarin.Android.Sdk.props` to `Xamarin.Android.Sdk.targets`. This allows these properties to be evaluated *after* the values set in the user's project. I added a test that builds a library, checking that the `__AndroidLibraryProjects__.zip` `EmbeddedResource` has the correct contents.
jonathanpeppers
force-pushed
the
net5-outputtype-exe
branch
from
a90f00a to
7711017
Compare
jonathanpeppers
added a commit
to dotnet/maui-samples
that referenced
this pull request
Apr 29, 2020
* `$(OutputType)` = `Exe` is what flags an app vs library dotnet/android#4604 * New `Run` target dotnet/android#4609
jonathanpeppers
added a commit
to dotnet/maui-samples
that referenced
this pull request
Apr 29, 2020
* `$(OutputType)` = `Exe` is what flags an app vs library dotnet/android#4604 * New `Run` target dotnet/android#4609
jonathanpeppers
added a commit
to dotnet/maui-samples
that referenced
this pull request
Apr 29, 2020
* `$(OutputType)` = `Exe` is what flags an app vs library dotnet/android#4604 * New `Run` target dotnet/android#4609
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In .NET 5, Xamarin.iOS is already using
<OutputType>Exe<OutputType>to distinguish an iOS application vs an iOS class library.
Xamarin.Android, however, is checking the existence of
Properties/AndroidManifest.xml.This brings up some issues:
same convention to distinguish library vs applications on both iOS
and Android.
static void Mainmethod.OutputType=Exemakes sense, as it tells Roslyn to expect a
Mainmethod.To consolidate this, I propose:
$(OutputType)ofExeto set$(AndroidApplication)totrue. No longer look forAndroidManifest.xmlfor this default.$(OutputType)toLibrary, since we never want aMainmethod on Android.To make this work, I had to move these defaults from
Xamarin.Android.Sdk.propstoXamarin.Android.Sdk.targets. Thisallows these properties to be evaluated after the values set in the
user's project.
I added a test that builds a library, checking that the
__AndroidLibraryProjects__.zipEmbeddedResourcehas the correctcontents.