Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to xamarin/xamarin-android-tools/master@f5fcb9fd #4640

Merged
merged 2 commits into from
May 7, 2020
Merged

Bump to xamarin/xamarin-android-tools/master@f5fcb9fd #4640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
257f848
Bump to xamarin/xamarin-android-tools/master@f5fcb9fd
jonpryor Apr 30, 2020
560e837
Add release notes
jonpryor Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Documentation/release-notes/4640.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
#### Application and library build and deployment

* [GitHub PR 79](https://github.com/xamarin/xamarin-android-tools/commit/f473ff9):
May address an `ArgumentException` observed on Windows machine when the
Registry contains an invalid path to the Android SDK.
Comment on lines +3 to +5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on if it would it be OK to mention the Developer Community item? I was sneaky and added a draft release note idea for that xamarin-android-tools PR in a post-merge comment there:

#### Application and library build and deployment

  * [Developer Community](https://developercommunity.visualstudio.com/content/problem/883179/ilegal-characters-in-path-after-fresh-install.html):
    *System.ArgumentException: Illegal characters in path* could prevent
    successful automatic detection of the Android SDK location during builds in
    some cases if an `AndroidSdkDirectory` registry value was set for
    Xamarin.Android that contained unexpected characters.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"OK"? Yes? I was kinda hoping to avoid mentioning it, because we're not entirely sure it'll fix the problem. (We think it will, but as repro'ing that issue is "weird," we could be wrong.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'd say "yes, we should mention devcom issues." It's this case which makes me wary.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah, that's fair. Works for me. Thanks for the sanity check. Feel free to merge with the current wording.

2 changes: 1 addition & 1 deletion external/xamarin-android-tools
Open in desktop
Submodule xamarin-android-tools updated from 12f52a to f5fcb9