[tests] combine 3 test assemblies into Xamarin.Android.Build.Tests #4961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moving the following assemblies into `Xamarin.Android.Build.Tasks.dll`: * `CodeBehindUnitTests.dll` * `EmbeddedDSOTests.dll` * `Xamarin.Android.MakeBundle-UnitTests.dll` This will simplify the `.yaml` definitions for running these tests and makes it possible to parameterize them for a future `One .NET` test phase. The only code changes are: * Move any classes in the top-level namespace to nested classes. * Add a `BaseTest.GetPathToZipAlign()` method instead of generating `Config.cs` at build time. These tests are still passing.
jonathanpeppers
force-pushed
the
move-tests-around
branch
from
fb5b6bc to
2826a6a
Compare
Member
Author
|
I spot checked a test from each assembly, and they are running & passing on Node-2:
|
jonathanpeppers
requested review from
grendello and
jpobst
and removed request for
jpobst
grendello
approved these changes
Jul 30, 2020
dellis1972
approved these changes
Jul 30, 2020
jonpryor
pushed a commit
that referenced
this pull request
Aug 3, 2020
…4961) Moving the following assemblies into `Xamarin.Android.Build.Tasks.dll`: * `CodeBehindUnitTests.dll` * `EmbeddedDSOTests.dll` * `Xamarin.Android.MakeBundle-UnitTests.dll` This will simplify the `.yaml` definitions for running these tests and makes it possible to parameterize them for a future `One .NET` test phase. The only code changes are: * Move any classes in the top-level namespace to nested classes. * Add a `BaseTest.GetPathToZipAlign()` method instead of generating `Config.cs` at build time. These tests are still passing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the following assemblies into
Xamarin.Android.Build.Tasks.dll:CodeBehindUnitTests.dllEmbeddedDSOTests.dllXamarin.Android.MakeBundle-UnitTests.dllThis will simplify the
.yamldefinitions for running these tests andmakes it possible to parameterize them for a future
One .NETtestphase.
The only code changes are:
BaseTest.GetPathToZipAlign()method instead of generatingConfig.csat build time.These tests are still passing.