[LibZipSharp] Bump to Version 1.0.20 #4976

dellis1972 · 2020-08-04T12:47:10Z

Fixes the issue with a native crash on windows.
The actual patch for libzip can be found at nih-at/libzip#202.
However LibZipSharp is currently applying that patch manually via dotnet/android-libzipsharp#67 to fix the issue in v1.7.3 of libzip. This is because the fix might not land for a while.

dellis1972 · 2020-08-04T14:26:35Z

The error for reference

Unhandled Exception: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
   at Xamarin.Tools.Zip.Native.zip_stat_index(IntPtr archive, UInt64 index, OperationFlags flags, zip_stat_t& sb)
   at Xamarin.Tools.Zip.ZipArchive.ReadEntry(UInt64 index, Boolean throwIfDeleted) in /Users/runner/work/1/s/ZipArchive.cs:line 713
   at Xamarin.Tools.Zip.ZipArchive.AddStream(Stream stream, String archivePath, EntryPermissions permissions, CompressionMethod compressionMethod, Boolean overwriteExisting, Nullable`1 modificationTime) in /Users/runner/work/1/s/ZipArchive.cs:line 334
   at Xamarin.Tools.Zip.ZipArchive.AddFile(String sourcePath, String archivePath, EntryPermissions permissions, CompressionMethod compressionMethod, Boolean overwriteExisting) in /Users/runner/work/1/s/ZipArchive.cs:line 405
   at Xamarin.Android.Tasks.BuildApk.AddFileToArchiveIfNewer(ZipArchiveEx apk, String file, String inArchivePath, CompressionMethod compressionMethod)
   at Xamarin.Android.Tasks.BuildApk.AddAssemblies(ZipArchiveEx apk, Boolean debug, Boolean compress, IDictionary`2 compressedAssembliesInfo)
   at Xamarin.Android.Tasks.BuildApk.ExecuteWithAbi(String[] supportedAbis, String apkInputPath, String apkOutputPath, Boolean debug, Boolean compress, IDictionary`2 compressedAssembliesInfo)
   at Xamarin.Android.Tasks.BuildApk.RunTask()
   at Xamarin.Android.Tasks.AndroidTask.Execute()
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
   at Microsoft.Build.BackEnd.TaskBuilder.<InitializeAndExecuteTask>d__24.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TaskBuilder.InitializeAndExecuteTask(TaskLoggingContext taskLoggingContext, ItemBucket bucket, IDictionary`2 taskIdentityParameters, TaskHost taskHost, TaskExecutionMode howToExecuteTask)
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteBucket>d__19.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteBucket(TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask, Dictionary`2 lookupHash)
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteTask>d__18.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteTask(TaskExecutionMode mode, Lookup lookup)
   at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteTask>d__13.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteTask(TargetLoggingContext loggingContext, BuildRequestEntry requestEntry, ITargetBuilderCallback targetBuilderCallback, ProjectTargetInstanceChild taskInstance, TaskExecutionMode mode, Lookup inferLookup, Lookup executeLookup, CancellationToken cancellationToken)
   at Microsoft.Build.BackEnd.TargetEntry.<ProcessBucket>d__51.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TargetEntry.ProcessBucket(ITaskBuilder taskBuilder, TargetLoggingContext targetLoggingContext, TaskExecutionMode mode, Lookup lookupForInference, Lookup lookupForExecution)
   at Microsoft.Build.BackEnd.TargetEntry.<ExecuteTarget>d__44.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TargetEntry.ExecuteTarget(ITaskBuilder taskBuilder, BuildRequestEntry requestEntry, ProjectLoggingContext projectLoggingContext, CancellationToken cancellationToken)
   at Microsoft.Build.BackEnd.TargetBuilder.<ProcessTargetStack>d__21.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TargetBuilder.ProcessTargetStack(ITaskBuilder taskBuilder)
   at Microsoft.Build.BackEnd.TargetBuilder.<BuildTargets>d__10.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.TargetBuilder.BuildTargets(ProjectLoggingContext loggingContext, BuildRequestEntry entry, IRequestBuilderCallback callback, String[] targetNames, Lookup baseLookup, CancellationToken cancellationToken)
   at Microsoft.Build.BackEnd.RequestBuilder.<BuildProject>d__58.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.RequestBuilder.BuildProject()
   at Microsoft.Build.BackEnd.RequestBuilder.<BuildAndReport>d__50.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.RequestBuilder.BuildAndReport()
   at Microsoft.Build.BackEnd.RequestBuilder.<RequestThreadProc>d__49.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at Microsoft.Build.BackEnd.RequestBuilder.RequestThreadProc(Boolean setThreadParameters)
   at Microsoft.Build.BackEnd.RequestBuilder.<StartBuilderThread>b__45_2()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
   at System.Threading.Tasks.Task.ExecutionContextCallback(Object obj)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot)
   at System.Threading.Tasks.Task.ExecuteEntry(Boolean bPreventDoubleExecution)
   at System.Threading.Tasks.TaskScheduler.TryExecuteTask(Task task)
   at Microsoft.Build.BackEnd.RequestBuilder.DedicatedThreadsTaskScheduler.<InjectThread>b__6_0()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

dellis1972 · 2020-08-05T14:37:25Z

/azp run

azure-pipelines · 2020-08-05T14:37:51Z

Azure Pipelines successfully started running 1 pipeline(s).

dellis1972 · 2020-08-05T15:51:38Z

Something is broken :'(

  C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018: The "UnzipDirectoryChildren" task failed unexpectedly. [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018: System.AggregateException: One or more errors occurred. ---> System.DllNotFoundException: Unable to load DLL 'libzip': The specified module could not be found. (Exception from HRESULT: 0x8007007E) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.Native.zip_open(IntPtr path, OpenFlags flags, ErrorCode& errorp) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.Native.zip_open(String path, OpenFlags flags, ErrorCode& errorp) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.ZipArchive.Open(String path, OpenFlags flags) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.ZipArchive.Open(String path, FileMode mode, String defaultExtractionDir, Boolean strictConsistencyChecks, IPlatformOptions options) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Android.Tools.BootstrapTasks.UnzipDirectoryChildren.ExtractFile(String sourceFile, String relativeDestDir, String destinationFolder, Encoding encoding) in C:\agent\_work\2\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks\UnzipDirectoryChildren.cs:line 63 [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Android.Tools.BootstrapTasks.UnzipDirectoryChildren.<>c__DisplayClass16_0.<Execute>b__0() in C:\agent\_work\2\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks\UnzipDirectoryChildren.cs:line 51 [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at System.Threading.Tasks.Task.InnerInvoke() [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at System.Threading.Tasks.Task.Execute() [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    --- End of inner exception stack trace --- [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at System.Threading.Tasks.Task.WaitAll(Task[] tasks, Int32 millisecondsTimeout, CancellationToken cancellationToken) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Android.Tools.BootstrapTasks.UnzipDirectoryChildren.Execute() in C:\agent\_work\2\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks\UnzipDirectoryChildren.cs:line 54 [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute() [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.<ExecuteInstantiatedTask>d__26.MoveNext() [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018: ---> (Inner Exception #0) System.DllNotFoundException: Unable to load DLL 'libzip': The specified module could not be found. (Exception from HRESULT: 0x8007007E) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.Native.zip_open(IntPtr path, OpenFlags flags, ErrorCode& errorp) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.Native.zip_open(String path, OpenFlags flags, ErrorCode& errorp) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.ZipArchive.Open(String path, OpenFlags flags) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Tools.Zip.ZipArchive.Open(String path, FileMode mode, String defaultExtractionDir, Boolean strictConsistencyChecks, IPlatformOptions options) [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Android.Tools.BootstrapTasks.UnzipDirectoryChildren.ExtractFile(String sourceFile, String relativeDestDir, String destinationFolder, Encoding encoding) in C:\agent\_work\2\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks\UnzipDirectoryChildren.cs:line 63 [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at Xamarin.Android.Tools.BootstrapTasks.UnzipDirectoryChildren.<>c__DisplayClass16_0.<Execute>b__0() in C:\agent\_work\2\s\build-tools\Xamarin.Android.Tools.BootstrapTasks\Xamarin.Android.Tools.BootstrapTasks\UnzipDirectoryChildren.cs:line 51 [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at System.Threading.Tasks.Task.InnerInvoke() [C:\agent\_work\2\s\src\aapt2\aapt2.csproj]
C:\agent\_work\2\s\src\aapt2\aapt2.targets(49,5): error MSB4018:    at System.Threading.Tasks.Task.Execute()<-

jonpryor · 2020-08-11T21:31:41Z

Squash-and-merge commit-

Summary:

Bump to xamarin/LibZipSharp/master@1752f95d

Body:

Fixes: https://github.com/xamarin/LibZipSharp/issues/64

Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1139578
Context: https://liquid.microsoft.com/Web/Object/Read/ms.security/Requirements/Microsoft.Security.SystemsADM.10039#guide

Changes: https://github.com/xamarin/libzipsharp/compare/1.0.10...1.0.20

  * xamarin/LibZipSharp@1752f95: Statically Linux libzip.so (#70)
  * xamarin/LibZipSharp@2b1762f: Fix Dll SearchPath to include Assembly Directory. (#69)
  * xamarin/LibZipSharp@28b4639: Merge pull request #68 from dellis1972/fixwindowssearch
  * xamarin/LibZipSharp@fdabcda: Fix Windows to look in Assembly Directory for 32bit dll.
  * xamarin/LibZipSharp@b332af0: Fix Native Crash on Windows. (#67)
  * xamarin/LibZipSharp@96eb5e3: Use DefaultDllImportSearchPathsAttribute (#66)
  * xamarin/LibZipSharp@755a42a: Bump libzip to 1.7.3 and go back to mingw (#65)
  * xamarin/LibZipSharp@5ae5e70: Merge pull request #60 from xamarin/msvc-static-link
  * xamarin/LibZipSharp@30ff680: Build libzip with static CRT and VS2019
  * xamarin/LibZipSharp@bad320e: Merge pull request #59 from dellis1972/theswitcharoo
  * xamarin/LibZipSharp@d7bc2c5: Merge pull request #58 from xamarin/optimize-winbuild
  * xamarin/LibZipSharp@34dc213: Make 64 bit Linux native lib the default.
  * xamarin/LibZipSharp@d3aad35: fixup! Optimize libzip build
  * xamarin/LibZipSharp@0970a01: Optimize libzip build
  * xamarin/LibZipSharp@d321af1: Merge pull request #57 from xamarin/fix-win32-packaging
  * xamarin/LibZipSharp@80b739d: Fix a typo which caused 64-bit dll to be packaged for 32-bit Windows
  * xamarin/LibZipSharp@1665db0: Bump the version (to 1.0.12), to prepare to release (#56)
  * xamarin/LibZipSharp@dd5e939: Throw exception instead of silently failing if zip save/close fails (#54)
  * xamarin/LibZipSharp@2df5b16: Fix enumerating zip with deleted entries (#53)
  * xamarin/LibZipSharp@a042554: Add .editorconfig, copied from xamarin-android (#55)
  * xamarin/LibZipSharp@a0973d4: Bump libzip to 1.6.1 (#49)

Changes: https://github.com/nih-at/libzip/compare/rel-1-5-1...v1.7.3

  * Context: https://libzip.org/news/release-1.7.3.html
  * Context: https://libzip.org/news/release-1.7.2.html
  * Context: https://libzip.org/news/release-1.7.1.html
  * Context: https://libzip.org/news/release-1.7.0.html

Two primary changes of note in this xamarin/LibZipSharp bump:

 1. Bump to `libzip` 1.7.3, which contains numerious fixes and
    improvements over the previously used 1.5.1 release.

 2. Use of `DefaultDllImportSearchPathsAttribute` so that native
    library dependencies are loaded securely, i.e. w/o allowing
    "other" libraries to be loaded from unsafe directories.

Unfortunately, the `libzip` bump itself caused issues, PR #4751 and
PR #4937 each had integration tests "randomly" SIGSEGV.  This was
eventually tracked down to a bug within `libzip` itself, fixed at:

  * https://github.com/nih-at/libzip/pull/202

Fixes: dotnet/android-libzipsharp#64 Context: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1139578 Context: https://liquid.microsoft.com/Web/Object/Read/ms.security/Requirements/Microsoft.Security.SystemsADM.10039#guide Changes: dotnet/android-libzipsharp@1.0.10...1.0.20 * dotnet/android-libzipsharp@1752f95: Statically Linux libzip.so (#70) * dotnet/android-libzipsharp@2b1762f: Fix Dll SearchPath to include Assembly Directory. (#69) * dotnet/android-libzipsharp@28b4639: Merge pull request #68 from dellis1972/fixwindowssearch * dotnet/android-libzipsharp@fdabcda: Fix Windows to look in Assembly Directory for 32bit dll. * dotnet/android-libzipsharp@b332af0: Fix Native Crash on Windows. (#67) * dotnet/android-libzipsharp@96eb5e3: Use DefaultDllImportSearchPathsAttribute (#66) * dotnet/android-libzipsharp@755a42a: Bump libzip to 1.7.3 and go back to mingw (#65) * dotnet/android-libzipsharp@5ae5e70: Merge pull request #60 from xamarin/msvc-static-link * dotnet/android-libzipsharp@30ff680: Build libzip with static CRT and VS2019 * dotnet/android-libzipsharp@bad320e: Merge pull request #59 from dellis1972/theswitcharoo * dotnet/android-libzipsharp@d7bc2c5: Merge pull request #58 from xamarin/optimize-winbuild * dotnet/android-libzipsharp@34dc213: Make 64 bit Linux native lib the default. * dotnet/android-libzipsharp@d3aad35: fixup! Optimize libzip build * dotnet/android-libzipsharp@0970a01: Optimize libzip build * dotnet/android-libzipsharp@d321af1: Merge pull request #57 from xamarin/fix-win32-packaging * dotnet/android-libzipsharp@80b739d: Fix a typo which caused 64-bit dll to be packaged for 32-bit Windows * dotnet/android-libzipsharp@1665db0: Bump the version (to 1.0.12), to prepare to release (#56) * dotnet/android-libzipsharp@dd5e939: Throw exception instead of silently failing if zip save/close fails (#54) * dotnet/android-libzipsharp@2df5b16: Fix enumerating zip with deleted entries (#53) * dotnet/android-libzipsharp@a042554: Add .editorconfig, copied from xamarin-android (#55) * dotnet/android-libzipsharp@a0973d4: Bump libzip to 1.6.1 (#49) Changes: nih-at/libzip@rel-1-5-1...v1.7.3 * Context: https://libzip.org/news/release-1.7.3.html * Context: https://libzip.org/news/release-1.7.2.html * Context: https://libzip.org/news/release-1.7.1.html * Context: https://libzip.org/news/release-1.7.0.html Two primary changes of note in this xamarin/LibZipSharp bump: 1. Bump to `libzip` 1.7.3, which contains numerious fixes and improvements over the previously used 1.5.1 release. 2. Use of `DefaultDllImportSearchPathsAttribute` so that native library dependencies are loaded securely, i.e. w/o allowing "other" libraries to be loaded from unsafe directories. Unfortunately, the `libzip` bump itself caused issues, PR #4751 and PR #4937 each had integration tests "randomly" SIGSEGV. This was eventually tracked down to a bug within `libzip` itself, fixed at: * nih-at/libzip#202

dellis1972 added the do-not-merge PR should not be merged. label Aug 4, 2020

dellis1972 requested a review from jonpryor as a code owner August 4, 2020 12:47

dellis1972 force-pushed the bumplibzip1.0.14 branch from 23873e8 to 0bb22cb Compare August 5, 2020 14:33

dellis1972 changed the title ~~[LibZipSharp] Bump to Version 1.0.16 [DO NOT MERGE]~~ [LibZipSharp] Bump to Version 1.0.17 Aug 5, 2020

dellis1972 removed the do-not-merge PR should not be merged. label Aug 5, 2020

dellis1972 requested a review from grendello August 5, 2020 14:36

grendello approved these changes Aug 5, 2020

View reviewed changes

dellis1972 added the do-not-merge PR should not be merged. label Aug 5, 2020

dellis1972 force-pushed the bumplibzip1.0.14 branch from 0bb22cb to 39df765 Compare August 6, 2020 09:18

dellis1972 changed the title ~~[LibZipSharp] Bump to Version 1.0.17~~ [LibZipSharp] Bump to Version 1.0.18 Aug 6, 2020

dellis1972 force-pushed the bumplibzip1.0.14 branch 2 times, most recently from 9b24c55 to 9a58e31 Compare August 7, 2020 10:25

dellis1972 changed the title ~~[LibZipSharp] Bump to Version 1.0.18~~ [LibZipSharp] Bump to Version 1.0.19 Aug 7, 2020

[LibZipSharp] Bump to Version 1.0.20

639506d

dellis1972 force-pushed the bumplibzip1.0.14 branch from 9a58e31 to 639506d Compare August 10, 2020 10:10

dellis1972 changed the title ~~[LibZipSharp] Bump to Version 1.0.19~~ [LibZipSharp] Bump to Version 1.0.20 Aug 10, 2020

dellis1972 removed the do-not-merge PR should not be merged. label Aug 10, 2020

dellis1972 requested a review from directhex as a code owner August 10, 2020 13:18

dellis1972 force-pushed the bumplibzip1.0.14 branch from 1c7057d to 639506d Compare August 10, 2020 18:55

Try to fix OSS Linux build

87ba4f7

dellis1972 requested a review from jonathanpeppers as a code owner August 11, 2020 10:42

Try this

69e171c

jonathanpeppers approved these changes Aug 11, 2020

View reviewed changes

grendello merged commit e86ee4c into dotnet:master Aug 12, 2020

dellis1972 deleted the bumplibzip1.0.14 branch August 12, 2020 09:21

brendanzagaeski added this to the In Preview: 11.1 (d16-8) milestone Sep 14, 2020

github-actions bot locked and limited conversation to collaborators Jan 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[LibZipSharp] Bump to Version 1.0.20 #4976

[LibZipSharp] Bump to Version 1.0.20 #4976

Uh oh!

dellis1972 commented Aug 4, 2020 •

edited

Loading

Uh oh!

dellis1972 commented Aug 4, 2020

Uh oh!

dellis1972 commented Aug 5, 2020

Uh oh!

azure-pipelines bot commented Aug 5, 2020

Uh oh!

dellis1972 commented Aug 5, 2020

Uh oh!

jonpryor commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[LibZipSharp] Bump to Version 1.0.20 #4976

[LibZipSharp] Bump to Version 1.0.20 #4976

Uh oh!

Conversation

dellis1972 commented Aug 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dellis1972 commented Aug 4, 2020

Uh oh!

dellis1972 commented Aug 5, 2020

Uh oh!

azure-pipelines bot commented Aug 5, 2020

Uh oh!

dellis1972 commented Aug 5, 2020

Uh oh!

jonpryor commented Aug 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dellis1972 commented Aug 4, 2020 •

edited

Loading