[tests/MSBuildDeviceIntegration] Add test for dll's which have the same size. #5229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekdoulik
reviewed
Oct 21, 2020
Member
radekdoulik
left a comment
radekdoulik
left a comment
There was a problem hiding this comment.
For peace of mind I would add one more Assert with check that the 2 assembly files are indeed the same size?
dellis1972
force-pushed
the
addsmallchangeunittest
branch
from
629c582 to
d7c4928
Compare
dellis1972
force-pushed
the
addsmallchangeunittest
branch
2 times, most recently
from
55536e7 to
f7ca41b
Compare
dellis1972
force-pushed
the
addsmallchangeunittest
branch
from
f7ca41b to
21e54a1
Compare
…me size. Context xamarin/monodroid#1123 There seems to be a bug in the new fast deployment system where if the dll was modified BUT had exactly the same size as the existing dll on the device it would not be uploade. This commit adds a test to make sure this does work as expected.
dellis1972
force-pushed
the
addsmallchangeunittest
branch
from
21e54a1 to
dbbe152
Compare
jonathanpeppers
approved these changes
Jan 8, 2021
jonpryor
pushed a commit
that referenced
this pull request
Jan 15, 2021
Context: https://github.com/xamarin/monodroid/issues/1123 There seems to be a bug in the new fast deployment system where if the `.dll` was modified BUT had exactly the same size as the existing `.dll` on the device it would not be uploaded. This commit adds a test to make sure this does work as expected.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context https://github.com/xamarin/monodroid/issues/1123
There seems to be a bug in the new fast deployment system
where if the dll was modified BUT had exactly the same size
as the existing dll on the device it would not be uploade.
This commit adds a test to make sure this does work as
expected.