[Xamarin.Android.Build.Tasks] Update LintToolPath to the new location. #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
suggested changes
May 7, 2017
Contributor
jonpryor
left a comment
jonpryor
left a comment
There was a problem hiding this comment.
This should probably have some path probing and fallback checks so that older and newer locations are both supported.
For example, the unit tests on the PR builder are failing. :-)
Google moved the lint tool from tools to tools\bin.
Contributor
|
build |
Contributor
|
On the plus side, .apk+emulator tests are now working as intended. Yay. On the minus side, there are 18 failures in |
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 3, 2020
Changes: dotnet/java-interop@cdf840f...b33d183 Context: dotnet/java-interop#509 * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations (dotnet#582) * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (dotnet#589)
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Mar 4, 2020
Changes: dotnet/java-interop@cdf840f...b33d183 Context: dotnet/java-interop#509 * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations (dotnet#582) * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (dotnet#589)
jonpryor
added a commit
that referenced
this pull request
Mar 4, 2020
Changes: dotnet/java-interop@cdf840f...b33d183 Context: dotnet/java-interop#509 * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations (#582) * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (#589)
jonpryor
added a commit
that referenced
this pull request
Mar 4, 2020
Changes: dotnet/java-interop@daf7fd7...3dab5a0 Context: dotnet/java-interop#509 * dotnet/java-interop@b33d183: [Java.Interop] JniTypeManager optimizations (#582) * dotnet/java-interop@28b1fc9: [generator] Support using DIM to nest interface types. (#589)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google moved the lint tool from tools to tools\bin.