Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix top level build #6

Merged
merged 1 commit into from
Apr 25, 2016
Merged

Fix top level build #6

merged 1 commit into from
Apr 25, 2016

Commits on Apr 25, 2016

  1. Fix top level build 

    - Xamarin.Android.sln: Disable Java.Interop build from here. It is built
  from _BuildJavaInterop target

- Mono.Android.csproj: Add a ProjectReference to mono-runtimes project,
  but don't *use* the reference. We just need it be built before
  Mono.Android, so that we can resolve against the built mscorlib and
  friends here.

- Mono.Android.targets: Mono.Android build was failing because it could
  not find the referenced Java.Interop.dll in ResolveAssemblyReferences.
  This was because _BuildJavaInterop was set to build
  `BeforeTargets=ResolveReferences`. But the *real* resolution of
  references is done in targets defined in `ResolveReferencesDependsOn`.
  And that runs *before* the `BeforeTargets`! Which means that
  _BuildJavaInterop was running too late!

  Solution: `BeforeTargets=BeforeResolveReferences` - JonP !
    Ankit Jain committed Apr 25, 2016
    Configuration menu
    Copy the full SHA
    ff1fc7c View commit details
    Browse the repository at this point in the history