[One .NET] enable C# bindings for @(AndroidLibrary) #6056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet/maui#1475 A .NET 6 application project was failing to include C# bindings for `.aar` files, but `.jar` files were working. The workaround was to include: <LibraryProjectZip Include="myjavalibrary.aar" /> We had a test that checked this behavior for `.jar` files, but not `.aar` files. After reproducing the behavior in a test, I found the `_CategorizeAndroidLibraries` MSBuild target did not automatically setup the `@(LibraryProjectZip)` item group in .NET 6 application projects. `@(AndroidAarLibrary)` *was* being setup, which explained why the Java code made it to `classes.dex`, but C# bindings were missing. Updated the `_CategorizeAndroidLibraries` MSBuild target for this case.
dellis1972
approved these changes
Jun 29, 2021
jonathanpeppers
added a commit
that referenced
this pull request
Jun 30, 2021
Fixes: dotnet/maui#1475 A .NET 6 application project was failing to include C# bindings for `.aar` files, but `.jar` files were working. The workaround was to include: <LibraryProjectZip Include="myjavalibrary.aar" /> We had a test that checked this behavior for `.jar` files, but not `.aar` files. After reproducing the behavior in a test, I found the `_CategorizeAndroidLibraries` MSBuild target did not automatically setup the `@(LibraryProjectZip)` item group in .NET 6 application projects. `@(AndroidAarLibrary)` *was* being setup, which explained why the Java code made it to `classes.dex`, but C# bindings were missing. Updated the `_CategorizeAndroidLibraries` MSBuild target for this case.
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Aug 25, 2021
Fixes: dotnet/maui#1475 A .NET 6 application project was failing to include C# bindings for `.aar` files, but `.jar` files were working. The workaround was to include: <LibraryProjectZip Include="myjavalibrary.aar" /> We had a test that checked this behavior for `.jar` files, but not `.aar` files. After reproducing the behavior in a test, I found the `_CategorizeAndroidLibraries` MSBuild target did not automatically setup the `@(LibraryProjectZip)` item group in .NET 6 application projects. `@(AndroidAarLibrary)` *was* being setup, which explained why the Java code made it to `classes.dex`, but C# bindings were missing. Updated the `_CategorizeAndroidLibraries` MSBuild target for this case.
jonpryor
pushed a commit
that referenced
this pull request
Aug 26, 2021
Fixes: dotnet/maui#1475 A .NET 6 application project was failing to include C# bindings for `.aar` files, but `.jar` files were working. The workaround was to include: <LibraryProjectZip Include="myjavalibrary.aar" /> We had a test that checked this behavior for `.jar` files, but not `.aar` files. After reproducing the behavior in a test, I found the `_CategorizeAndroidLibraries` MSBuild target did not automatically setup the `@(LibraryProjectZip)` item group in .NET 6 application projects. `@(AndroidAarLibrary)` *was* being setup, which explained why the Java code made it to `classes.dex`, but C# bindings were missing. Updated the `_CategorizeAndroidLibraries` MSBuild target for this case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/maui#1475
A .NET 6 application project was failing to include C# bindings for
.aarfiles, but.jarfiles were working.The workaround was to include:
We had a test that checked this behavior for
.jarfiles, but not.aarfiles.After reproducing the behavior in a test, I found the
_CategorizeAndroidLibrariesMSBuild target did not automaticallysetup the
@(LibraryProjectZip)item group in .NET 6 applicationprojects.
@(AndroidAarLibrary)was being setup, which explainedwhy the Java code made it to
classes.dex, but C# bindings weremissing.
Updated the
_CategorizeAndroidLibrariesMSBuild target for this case.