[Xamarin.Android.Build.Tasks] default $(AndroidUseAssemblyStore) to false for debug builds #6660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alse for debug builds Context: https://github.com/xamarin/QualityAssurance/tree/master/Manual/CrossPlatformDebugging Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1430409 Fixes: dotnet#6480 A `CrossPlatformDebugging` sample project in the QA repo fails to debug with: System.InvalidProgramException Message=Invalid IL code in Mono.SystemDependencyProvider:Initialize (): IL_002e: endfinally The problem goes away if you do one of: * Turn *on* Fast Deployment * Add `<AndroidUseAssemblyStore>false</AndroidUseAssemblyStore>` * Change `$(DebugType)` to `portable`. (the project has `full`) The problem appears to be: 1. `$(AndroidUseAssemblyStore)` defaults to `true` when you turn Fast Deployment *off*. 2. Assembly stores appear to have some issue when `DebugType=full` -- that is where the crash occurs. In this case let's address No. 1, as we don't *really* want the assembly store to be used when debugging. I reordered default values for MSBuild properties, so that `$(AndroidIncludeDebugSymbols)` is taken into account. I added parameters for a debugging test for `DebugType=full`, and I updated another test that used to set `AndroidUseAssemblyStore=false` that should not be needed.
jonathanpeppers
force-pushed
the
androiduseassemblystore-debug
branch
from
4f4b3c3 to
c79a682
Compare
grendello
approved these changes
Jan 24, 2022
|
Some networking/SSL failures seem to be the only failures: https://discord.com/channels/732297728826277939/732297837953679412/935538687968694402 Going to merge, I think. |
jonpryor
pushed a commit
that referenced
this pull request
Jan 26, 2022
…alse for debug builds (#6660) Context: https://github.com/xamarin/QualityAssurance/tree/master/Manual/CrossPlatformDebugging Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1430409 Fixes: #6480 A `CrossPlatformDebugging` sample project in the QA repo fails to debug with: System.InvalidProgramException Message=Invalid IL code in Mono.SystemDependencyProvider:Initialize (): IL_002e: endfinally The problem goes away if you do one of: * Turn *on* Fast Deployment * Add `<AndroidUseAssemblyStore>false</AndroidUseAssemblyStore>` * Change `$(DebugType)` to `portable`. (the project has `full`) The problem appears to be: 1. `$(AndroidUseAssemblyStore)` defaults to `true` when you turn Fast Deployment *off*. 2. Assembly stores appear to have some issue when `DebugType=full` -- that is where the crash occurs. In this case let's address No. 1, as we don't *really* want the assembly store to be used when debugging. I reordered default values for MSBuild properties, so that `$(AndroidIncludeDebugSymbols)` is taken into account. I added parameters for a debugging test for `DebugType=full`, and I updated another test that used to set `AndroidUseAssemblyStore=false` that should not be needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/xamarin/QualityAssurance/tree/master/Manual/CrossPlatformDebugging
Fixes: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1430409
Fixes: #6480
A
CrossPlatformDebuggingsample project in the QA repo fails todebug with:
The problem goes away if you do one of:
<AndroidUseAssemblyStore>false</AndroidUseAssemblyStore>$(DebugType)toportable. (the project hasfull)The problem appears to be:
$(AndroidUseAssemblyStore)defaults totruewhen you turn FastDeployment off.
Assembly stores appear to have some issue when
DebugType=full--that is where the crash occurs.
In this case let's address No. 1, as we don't really want the
assembly store to be used when debugging. I reordered default values
for MSBuild properties, so that
$(AndroidIncludeDebugSymbols)istaken into account.
I added parameters for a debugging test for
DebugType=full, and Iupdated another test that used to set
AndroidUseAssemblyStore=falsethat should not be needed.