[tests] enable .NET 7 LLVM tests without Profiled AOT #7030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has a different crash now... |
jonathanpeppers
force-pushed
the
llvm-no-profiled-aot
branch
from
10ef40d
to
5832b0c
Compare
|
If this one works, this time, I need to squash and completely redo the commit message/title on this one. |
|
I think the tests are crashing (something new?): I'll try this locally. |
jonathanpeppers
force-pushed
the
llvm-no-profiled-aot
branch
from
779047f
to
a510f5b
Compare
Context: dotnet/runtime#68914 We found that the issue with LLVM only occurs when using Profiled AOT. This is enabled by default for `Release` builds in .NET 6+, so let's try using `-p:AndroidEnableProfiledAot=false`. This at least gets some of our LLVM test coverage running again. When testing this, we started getting a crash: 05-24 15:11:36.809 5024 5024 F DEBUG : Abort message: 'Internal p/invoke symbol 'java-interop @ java_interop_jvm_list' (hash: 0x58c48fc8b89cb484) not found in compile-time map.' It appeared that `Android.App.Application.cctor` was running before `JNIEnv.Initialize()` is complete: 05-25 11:12:33.177 10812 10812 D Mono : AOT: FOUND method Android.Runtime.JNIEnv/<>c:.cctor () [0x78e0d04608 - 0x78e0d04678 0x78e0d6f8a0] 05-25 11:12:33.177 10812 10812 D Mono : Running class .cctor for Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager from 'Mono.Android.dll' 05-25 11:12:33.177 10812 10812 D Mono : AOT: FOUND method Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager:.cctor () [0x78e0d31d24 - 0x78e0d31d64 0x78e0d6f8a0] 05-25 11:12:33.177 10812 10812 D Mono : Running class .cctor for Android.App.Application from 'Mono.Android.dll' By adding an explicit static constructor to `Android.App.Application`, this appears to have workaround this issue.
TODO commit message
jonathanpeppers
force-pushed
the
llvm-no-profiled-aot
branch
from
a510f5b
to
71eb08d
Compare
|
Ok, one interesting failure: |
|
Closing in favor of: #7188 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/runtime#68914
We found that the issue with LLVM only occurs when using Profiled AOT.
This is enabled by default for
Releasebuilds in .NET 6+, so let'stry using
-p:AndroidEnableProfiledAot=false.This at least gets some of our LLVM test coverage running again.
When testing this, we started getting a crash:
It appeared that
Android.App.Application.cctorwas running beforeJNIEnv.Initialize()is complete:By adding an explicit static constructor to
Android.App.Application,this appears to have workaround this issue.