[build] Don't install FSharp.Core assemblies #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to get #740 working and merged to fix the errors in this PR. |
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58689 Context: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#FSharpCore We [removed `FSharp.Core.dll` from the commercial product][1] because it's presence was actively breaking things (due to still-not-understood changes around Visual Studio and MSBuild): [1]: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#FSharpCore > the `FSharp.Core.dll` distributed with Xamarin.Android is now being > used in preference to the NuGet package, through no changes on the > Xamarin.Android side of things. This means that the NuGet package > cannot be used Remove the `FSharp.Core` assemblies from the OSS side of things. Developers wishing to use F# and the `FSharp.Core` assemblies should use the [`FSharp.Core` NuGet package][2]. [2]: https://www.nuget.org/packages/FSharp.Core/
jonpryor
force-pushed
the
jonp-expunge-fsharp
branch
from
cf57be8
to
760bf35
Compare
jonpryor
added a commit
that referenced
this pull request
Aug 11, 2017
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58689 Context: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#FSharpCore We [removed `FSharp.Core.dll` from the commercial product][1] because it's presence was actively breaking things (due to still-not-understood changes around Visual Studio and MSBuild): [1]: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#FSharpCore > the `FSharp.Core.dll` distributed with Xamarin.Android is now being > used in preference to the NuGet package, through no changes on the > Xamarin.Android side of things. This means that the NuGet package > cannot be used Remove the `FSharp.Core` assemblies from the OSS side of things. Developers wishing to use F# and the `FSharp.Core` assemblies should use the [`FSharp.Core` NuGet package][2]. [2]: https://www.nuget.org/packages/FSharp.Core/
jonpryor
pushed a commit
that referenced
this pull request
Oct 20, 2020
Fixes: dotnet/java-interop#461 Fixes: dotnet/java-interop#682 Fixes: dotnet/java-interop#717 Fixes: dotnet/java-interop#719 Fixes: dotnet/java-interop#728 Changes: dotnet/java-interop@ac914ce...b991bb8 * dotnet/java-interop@b991bb86: [generator] Revert change to use auto-properties in EventArgs classes (#736) * dotnet/java-interop@ee50d89b: Bump to xamarin/xamarin-android-tools/master@f2af06f2 (#733) * dotnet/java-interop@a0b895c1: [build] Suppress NuGet warnings (#730) * dotnet/java-interop@8b1b0507: [generator] Fix parsing of complex generic types (#729) * dotnet/java-interop@ee7afeed: [generator] Prevent generating duplicate EventArgs classes (#726) * dotnet/java-interop@1f21f38c: [generator] Use GC.KeepAlive for reference type method parameters. (#725) * dotnet/java-interop@5136ef98: [Xamarin.Android.Tools.Bytecode] Hide Kotlin nested types inside (#723) * dotnet/java-interop@53d60513: [jnimarshalmethod-gen] Fix registration on Windows (#721) * dotnet/java-interop@5a834d42: [jnimarshalmethod-gen] Avoid creating AppDomains (#720) * dotnet/java-interop@a76edb8c: [Xamarin.Android.Tools.ApiXmlAdjuster] Find app.android.IntentService (#718) * dotnet/java-interop@6cde0877: [Java.Interop] Emit a reference assembly for Java.Interop.dll (#716) * dotnet/java-interop@b858dc59: [generator] Provide line/col numbers for api.xml warnings (#715) * dotnet/java-interop@9be92a04: [ci] Don't kick off CI for documentation only changes. (#712) * dotnet/java-interop@03c22722: [jnimarshalmethod-gen] Fix type resolution crash (#706)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58689
Context: https://developer.xamarin.com/releases/android/xamarin.android_7/xamarin.android_7.4/#FSharpCore
We removed
FSharp.Core.dllfrom the commercial productbecause it's presence was actively breaking things (due to
still-not-understood changes around Visual Studio and MSBuild):
Remove the
FSharp.Coreassemblies from the OSS side of things.Developers wishing to use F# and the
FSharp.Coreassemblies shoulduse the
FSharp.CoreNuGet package.